From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Max Reitz <mreitz@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
"jsnow@redhat.com" <jsnow@redhat.com>,
Denis Lunev <den@virtuozzo.com>
Subject: Re: [Qemu-devel] [PATCH v7 5/5] block/backup: refactor: split out backup_calculate_cluster_size
Date: Mon, 13 May 2019 09:54:08 +0000 [thread overview]
Message-ID: <e2d76438-1454-97a2-91b6-47f95941a022@virtuozzo.com> (raw)
In-Reply-To: <b0604566-ec0d-a072-ce5d-713369af6c4c@redhat.com>
09.05.2019 19:12, Max Reitz wrote:
> On 29.04.19 11:08, Vladimir Sementsov-Ogievskiy wrote:
>> Split out cluster_size calculation. Move copy-bitmap creation above
>> block-job creation, as we are going to share it with upcoming
>> backup-top filter, which also should be created before actual block job
>> creation.
>>
>> Also, while being here, drop unnecessary "goto error" from
>> bdrv_getlength error path.
>
> This paragraph should be dropped now. Do you mind me doing it?
>
Of course, don't mind)
--
Best regards,
Vladimir
next prev parent reply other threads:[~2019-05-13 9:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 9:08 [Qemu-devel] [PATCH v7 0/5] backup-top: preparing refactoring Vladimir Sementsov-Ogievskiy
2019-04-29 9:08 ` Vladimir Sementsov-Ogievskiy
2019-04-29 9:08 ` [Qemu-devel] [PATCH v7 1/5] block/backup: simplify backup_incremental_init_copy_bitmap Vladimir Sementsov-Ogievskiy
2019-04-29 9:08 ` Vladimir Sementsov-Ogievskiy
2019-04-29 9:08 ` [Qemu-devel] [PATCH v7 2/5] block/backup: move to copy_bitmap with granularity Vladimir Sementsov-Ogievskiy
2019-04-29 9:08 ` Vladimir Sementsov-Ogievskiy
2019-04-29 9:08 ` [Qemu-devel] [PATCH v7 3/5] block/backup: refactor and tolerate unallocated cluster skipping Vladimir Sementsov-Ogievskiy
2019-04-29 9:08 ` Vladimir Sementsov-Ogievskiy
2019-04-29 9:08 ` [Qemu-devel] [PATCH v7 4/5] block/backup: unify different modes code path Vladimir Sementsov-Ogievskiy
2019-04-29 9:08 ` Vladimir Sementsov-Ogievskiy
2019-04-29 9:08 ` [Qemu-devel] [PATCH v7 5/5] block/backup: refactor: split out backup_calculate_cluster_size Vladimir Sementsov-Ogievskiy
2019-04-29 9:08 ` Vladimir Sementsov-Ogievskiy
2019-05-09 16:12 ` Max Reitz
2019-05-13 9:54 ` Vladimir Sementsov-Ogievskiy [this message]
2019-05-13 13:41 ` [Qemu-devel] [PATCH v7 0/5] backup-top: preparing refactoring Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2d76438-1454-97a2-91b6-47f95941a022@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).