From: "Cédric Le Goater" <clg@kaod.org>
To: "'qemu-arm@nongnu.org'" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: 'Andrew Jeffery' <andrew@codeconstruct.com.au>,
Joel Stanley <joel@jms.id.au>,
'Jamin Lin' <jamin_lin@aspeedtech.com>,
Steven Lee <steven_lee@aspeedtech.com>,
Troy Lee <leetroy@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
Patrick Williams <patrick@stwcx.xyz>
Subject: aspeed: Split the machine definition into individual source files
Date: Thu, 19 Jun 2025 11:23:53 +0200 [thread overview]
Message-ID: <e2df1ff1-3ce4-4233-b32e-2bc680725c71@kaod.org> (raw)
Hi,
This is a follow up of a private discussion with Patrick.
Aspeed modeling started nearly 10y ago with the palmetto-bmc machine.
We now have 5 SoCs and 25 machines which are mostly defined in
in a single aspeed.c file. Multi SoC machines, fby35 and ast2700fc,
are defined in fby35.c and aspeed_ast27x0-fc.c respectively.
Since we started separating the SoCs :
hw/arm/aspeed_ast10x0.c
hw/arm/aspeed_ast2400.c
hw/arm/aspeed_ast2600.c
hw/arm/aspeed_ast27x0.c
hw/arm/aspeed_ast27x0-ssp.c
hw/arm/aspeed_ast27x0-tsp.c
We could do the same for the machines keeping an 'aspeed_ast<rev>'
prefix (and maybe avoid the 'bmc' suffix). I think this would ease
introduction of new machines. We would be able to get rid of
aspeed_eeprom.[ch] and move machine custom data in the machine source
file. Which seems cleaner.
Timing is about right for code reshuffling, still 3w before soft
freeze, no important changes inflight, but if we start doing this
conversion, we should do it for all. See the list below for the brave.
Comments ?
Thanks,
C.
* AST2400
palmetto-bmc
quanta-q71l-bmc
supermicrox11-bmc
* AST2500
ast2500-evb
romulus-bmc
sonorapass-bmc
witherspoon-bmc
yosemitev2-bmc
supermicro-x11spi-bmc
fp5280g2-bmc
g220a-bmc
tiogapass-bmc
* AST2600
ast2600-evb
qcom-dc-scm-v1-bmc
qcom-firework-bmc
rainier-bmc
fuji-bmc
bletchley-bmc
fby35-bmc (fby35.c should rename to aspeed_ast2600-fby35.c)
* AST2700
ast2700a0-evb
ast2700a1-evb
ast2700fc (aspeed_ast27x0-fc.c)
* AST1030
ast1030-evb
next reply other threads:[~2025-06-19 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 9:23 Cédric Le Goater [this message]
2025-06-19 14:54 ` aspeed: Split the machine definition into individual source files Troy Lee
2025-06-20 7:13 ` Cédric Le Goater
2025-06-24 23:13 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2df1ff1-3ce4-4233-b32e-2bc680725c71@kaod.org \
--to=clg@kaod.org \
--cc=andrew@codeconstruct.com.au \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=leetroy@gmail.com \
--cc=patrick@stwcx.xyz \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).