From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8C6O-0006fU-T6 for qemu-devel@nongnu.org; Fri, 27 Oct 2017 17:23:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8C6O-0007BK-0N for qemu-devel@nongnu.org; Fri, 27 Oct 2017 17:23:40 -0400 References: <20171023092945.54532-1-vsementsov@virtuozzo.com> From: Eric Blake Message-ID: Date: Fri, 27 Oct 2017 23:23:12 +0200 MIME-Version: 1.0 In-Reply-To: <20171023092945.54532-1-vsementsov@virtuozzo.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HTtd3Qvflq2Ax5mkfrNKrlwFF6EEisJU2" Subject: Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: mreitz@redhat.com, kwolf@redhat.com, jsnow@redhat.com, famz@redhat.com, den@openvz.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HTtd3Qvflq2Ax5mkfrNKrlwFF6EEisJU2 From: Eric Blake To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: mreitz@redhat.com, kwolf@redhat.com, jsnow@redhat.com, famz@redhat.com, den@openvz.org, stefanha@redhat.com Message-ID: Subject: Re: [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch References: <20171023092945.54532-1-vsementsov@virtuozzo.com> In-Reply-To: <20171023092945.54532-1-vsementsov@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/23/2017 11:29 AM, Vladimir Sementsov-Ogievskiy wrote: > Snapshot-switch actually changes active state of disk so it should > reflect on dirty bitmaps. Otherwise next incremental backup using > these bitmaps will be invalid. >=20 > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/snapshot.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) Reviewed-by: Eric Blake --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org --HTtd3Qvflq2Ax5mkfrNKrlwFF6EEisJU2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAlnzo8AACgkQp6FrSiUn Q2r03Af/QL4CygxssgzpiBYuH9kZngVtmnky8iObnDuLTRAyNIa9E/AYQEsUkZ7c SeQHd3afS13UBEGw1GxrcBwP1oa7Lde3iuRgrtx2qQChbDXV/D6u50Dcr7YIvhxV EX8IwGt6XEbP9iAd2rPNWUS2FvUpvjjUW8aVkKNYFAp5B8zSkv0SrVXGE3JVESzK tHUb++xIj9WvK6jf7H8L12xh5/ybF3+YWCdqVZGVczIeotGZenJ/7UQ+OphjIKPx uB4aJUrIpfqfAAIsJ2mmZpg2Vm3WXtf2kU9teQGukdgTyQqQs71Wf0PTjJ0vemGu oUPHbREOIF3ZREyab9g1l6RS13xiTA== =crV1 -----END PGP SIGNATURE----- --HTtd3Qvflq2Ax5mkfrNKrlwFF6EEisJU2--