From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Akihiko Odaki <akihiko.odaki@daynix.com>,
Thomas Huth <th.huth@posteo.de>,
Prasad Pandit <pj.pandit@yahoo.in>,
Mauro Matteo Cascella <mcascell@redhat.com>
Cc: "Alexander Bulekov" <alxndr@bu.edu>,
"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
"Beniamino Galvani" <b.galvani@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Strahinja Jankovic" <strahinja.p.jankovic@gmail.com>,
"Jason Wang" <jasowang@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Stefan Weil" <sw@weilnetz.de>, "Cédric Le Goater" <clg@kaod.org>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Joel Stanley" <joel@jms.id.au>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Helge Deller" <deller@gmx.de>,
"Sriram Yagnaraman" <sriram.yagnaraman@est.tech>,
"Thomas Huth" <huth@tuxfamily.org>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
"Jan Kiszka" <jan.kiszka@web.de>,
"Tyrone Ting" <kfting@nuvoton.com>,
"Hao Wu" <wuhaotsh@google.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Jiri Pirko" <jiri@resnulli.us>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Greg Kurz" <groug@kaod.org>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Sven Schnelle" <svens@stackframe.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Paul Durrant" <paul@xen.org>, "Rob Herring" <robh@kernel.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 1/2] net: Provide MemReentrancyGuard * to qemu_new_nic()
Date: Fri, 26 Apr 2024 15:38:24 +0200 [thread overview]
Message-ID: <e2fb1d51-b5a6-4c25-a9af-af1e1ed42475@linaro.org> (raw)
In-Reply-To: <81397221-8144-47cd-bce9-b3ab7d94c626@daynix.com>
On 26/4/24 14:37, Akihiko Odaki wrote:
> On 2024/04/24 21:32, Thomas Huth wrote:
>> On 24/04/2024 12.41, Prasad Pandit wrote:
>>> On Wednesday, 24 April, 2024 at 03:36:01 pm IST, Philippe
>>> Mathieu-Daudé wrote:
>>>> On 1/6/23 05:18, Akihiko Odaki wrote:
>>>>> Recently MemReentrancyGuard was added to DeviceState to record that
>>>>> the
>>>>> device is engaging in I/O. The network device backend needs to
>>>>> update it
>>>>> when delivering a packet to a device.
>>>>> In preparation for such a change, add MemReentrancyGuard * as a
>>>>> parameter of qemu_new_nic().
>>>>
>>>> An user on IRC asked if this patch is related/fixing CVE-2021-20255,
>>>> any clue?
>>>
>>> * CVE-2021-20255 bug: infinite recursion is pointing at a different
>>> fix patch.
>>> -> https://bugzilla.redhat.com/show_bug.cgi?id=CVE-2021-20255
>>>
>>> * And the this patch below has different issue tagged
>>> -> https://lists.nongnu.org/archive/html/qemu-devel/2023-05/msg08312.html
>>> Fixes: CVE-2023-3019
>>>
>>>
>>> * They look different, former is an infinite recursion issue and the
>>> latter is a use-after-free one.
>>
>> I assume the eepro reentrancy issue has been fixed with:
>>
>> https://gitlab.com/qemu-project/qemu/-/issues/556
>> i.e.:
>> https://gitlab.com/qemu-project/qemu/-/commit/c40ca2301c7603524eaddb5308a3
>
> I agree. Commit c40ca2301c7603524eaddb5308a3 should be what fixed
> CVE-2021-20255, not this patch.
Thank you all for clarifying!
next prev parent reply other threads:[~2024-04-26 13:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 3:18 [PATCH v2 0/2] net: Update MemReentrancyGuard for NIC Akihiko Odaki
2023-06-01 3:18 ` [PATCH v2 1/2] net: Provide MemReentrancyGuard * to qemu_new_nic() Akihiko Odaki
2023-06-05 8:06 ` Alexander Bulekov
2023-06-05 10:50 ` Akihiko Odaki
2024-04-24 10:05 ` Philippe Mathieu-Daudé
2024-04-24 10:41 ` Prasad Pandit
2024-04-24 12:32 ` Thomas Huth
2024-04-26 12:37 ` Akihiko Odaki
2024-04-26 13:38 ` Philippe Mathieu-Daudé [this message]
2024-04-26 16:02 ` BALATON Zoltan
2023-06-01 3:18 ` [PATCH v2 2/2] net: Update MemReentrancyGuard for NIC Akihiko Odaki
2023-06-05 8:04 ` Alexander Bulekov
2023-06-01 7:16 ` [PATCH v2 0/2] " Philippe Mathieu-Daudé
2023-06-01 7:41 ` Akihiko Odaki
2023-06-01 8:56 ` Philippe Mathieu-Daudé
2023-09-21 7:16 ` Akihiko Odaki
2023-11-14 5:29 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2fb1d51-b5a6-4c25-a9af-af1e1ed42475@linaro.org \
--to=philmd@linaro.org \
--cc=akihiko.odaki@daynix.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alistair@alistair23.me \
--cc=alxndr@bu.edu \
--cc=andrew@aj.id.au \
--cc=anthony.perard@citrix.com \
--cc=b.galvani@gmail.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=deller@gmx.de \
--cc=dmitry.fleytman@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=groug@kaod.org \
--cc=harshpb@linux.ibm.com \
--cc=huth@tuxfamily.org \
--cc=jan.kiszka@web.de \
--cc=jasowang@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=jiri@resnulli.us \
--cc=joel@jms.id.au \
--cc=kfting@nuvoton.com \
--cc=kraxel@redhat.com \
--cc=mcascell@redhat.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=peter.maydell@linaro.org \
--cc=pj.pandit@yahoo.in \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=robh@kernel.org \
--cc=sriram.yagnaraman@est.tech \
--cc=sstabellini@kernel.org \
--cc=strahinja.p.jankovic@gmail.com \
--cc=sundeep.lkml@gmail.com \
--cc=svens@stackframe.org \
--cc=sw@weilnetz.de \
--cc=th.huth@posteo.de \
--cc=wuhaotsh@google.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).