From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
qemu-devel@nongnu.org
Cc: chenrui333@gmail.com
Subject: Re: [PATCH] target/tricore: Rename tricore_feature
Date: Fri, 21 Jul 2023 09:31:31 +0200 [thread overview]
Message-ID: <e30200d0-0c0f-c652-e926-fb305b515abe@linaro.org> (raw)
In-Reply-To: <20230721060605.76636-1-kbastian@mail.uni-paderborn.de>
On 21/7/23 08:06, Bastian Koppelmann wrote:
> this name is used by capstone and will lead to a build failure of QEMU,
> when capstone is enabled. So we rename it to tricore_has_feature(), to
> match has_feature() in translate.c.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1774
> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> ---
> target/tricore/cpu.c | 8 ++++----
> target/tricore/cpu.h | 2 +-
> target/tricore/helper.c | 4 ++--
> target/tricore/op_helper.c | 4 ++--
> 4 files changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-07-21 7:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 6:06 [PATCH] target/tricore: Rename tricore_feature Bastian Koppelmann
2023-07-21 6:35 ` Thomas Huth
2023-07-21 7:31 ` Philippe Mathieu-Daudé [this message]
2023-07-21 8:54 ` [PATCH-for-8.1] " Philippe Mathieu-Daudé
2023-07-21 10:01 ` Bastian Koppelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e30200d0-0c0f-c652-e926-fb305b515abe@linaro.org \
--to=philmd@linaro.org \
--cc=chenrui333@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).