Re: [PATCH v2 1/1] plugins: Move the windows linking function to qemu

[Paolo Bonzini <pbonzini@redhat.com>]

On 11/9/23 10:25, Greg Manning wrote:
> Previously, a plugin author needed an implementation of the
> __pfnDliFailureHook2 or __pfnDliNotifyHook2 hook in the plugin. Now all
> they need is a null exported pointer with the right name (as in
> win32_linker.c). If QEMU finds this, it will set it to the hook
> function, which has now moved into qemu (os-win32.c).
> 
> Signed-off-by: Greg Manning <gmanning@rapitasystems.com>
> ---

Thanks for trying! :)

I'm not sure how big an improvement this is, but I'll let Alex judge.

The main issue I had with win32_linker.c is the additional complexity 
for external plugins, which is now decreased but to some extent remains. 
  I should have made that clearer.  One possibility is to put the 
definition in a macro, and have the plugin sources simply expand the macro.

Paolo