From: Eric Blake <eblake@redhat.com>
To: Ricardo Perez Blanco <ricardo.perez_blanco@nokia.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list"
Date: Fri, 1 Jun 2018 11:01:17 -0500 [thread overview]
Message-ID: <e31963b7-b5c2-2cd4-92e6-7fc0ddbb881f@redhat.com> (raw)
In-Reply-To: <20180601153922.11590-1-ricardo.perez_blanco@nokia.com>
On 06/01/2018 10:39 AM, Ricardo Perez Blanco wrote:
> For debugging purposes it is very useful to:
> - See the description of the field. This information is already filled
> in but not shown in "qom-list" command.
> - Display value of the field.
>
> Signed-off-by: Ricardo Perez Blanco <ricardo.perez_blanco@nokia.com>
> ---
> +++ b/qapi/misc.json
> @@ -1328,10 +1328,12 @@
> #
> # @description: if specified, the description of the property.
> #
> -# Since: 1.2
> +# @value: if specified, the value of the property.
> +#
> +# Since: 2.13
Not quite. The struct was first introduced in 1.2, and only 'value' was
added in 3.0 (since we've renamed 2.13 into 3.0). It should look like:
# @value: if specified, the value of the property (since 3.0)
#
# Since: 1.2
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-06-01 16:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 15:39 [Qemu-devel] [PATCH v2] Show values and description when using "qom-list" Ricardo Perez Blanco
2018-06-01 16:01 ` Eric Blake [this message]
2018-06-11 7:18 ` Perez Blanco, Ricardo (Nokia - BE/Antwerp)
2018-06-02 7:20 ` Andreas Färber
2018-06-08 9:41 ` Dr. David Alan Gilbert
2018-06-08 16:19 ` Andreas Färber
2018-06-11 7:17 ` Perez Blanco, Ricardo (Nokia - BE/Antwerp)
2018-06-12 6:02 ` Markus Armbruster
2018-06-25 11:32 ` Markus Armbruster
2018-06-25 15:00 ` Dr. David Alan Gilbert
2018-06-25 18:42 ` Markus Armbruster
2018-06-29 12:17 ` Dr. David Alan Gilbert
2018-06-29 12:39 ` Perez Blanco, Ricardo (Nokia - BE/Antwerp)
2018-07-02 6:36 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e31963b7-b5c2-2cd4-92e6-7fc0ddbb881f@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ricardo.perez_blanco@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).