* [Qemu-devel] [PATCH v1 1/1] default-configs: Enable USB support for RISC-V machines
@ 2019-01-10 0:01 Alistair Francis
2019-01-10 8:33 ` Thomas Huth
2019-01-10 16:53 ` Palmer Dabbelt
0 siblings, 2 replies; 4+ messages in thread
From: Alistair Francis @ 2019-01-10 0:01 UTC (permalink / raw)
To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: Alistair Francis, alistair23@gmail.com
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
default-configs/riscv32-softmmu.mak | 1 +
default-configs/riscv64-softmmu.mak | 1 +
2 files changed, 2 insertions(+)
diff --git a/default-configs/riscv32-softmmu.mak b/default-configs/riscv32-softmmu.mak
index dbc9398284..c9c5971409 100644
--- a/default-configs/riscv32-softmmu.mak
+++ b/default-configs/riscv32-softmmu.mak
@@ -1,6 +1,7 @@
# Default configuration for riscv-softmmu
include pci.mak
+include usb.mak
CONFIG_SERIAL=y
CONFIG_VIRTIO_MMIO=y
diff --git a/default-configs/riscv64-softmmu.mak b/default-configs/riscv64-softmmu.mak
index dbc9398284..c9c5971409 100644
--- a/default-configs/riscv64-softmmu.mak
+++ b/default-configs/riscv64-softmmu.mak
@@ -1,6 +1,7 @@
# Default configuration for riscv-softmmu
include pci.mak
+include usb.mak
CONFIG_SERIAL=y
CONFIG_VIRTIO_MMIO=y
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] default-configs: Enable USB support for RISC-V machines
2019-01-10 0:01 [Qemu-devel] [PATCH v1 1/1] default-configs: Enable USB support for RISC-V machines Alistair Francis
@ 2019-01-10 8:33 ` Thomas Huth
2019-01-10 16:53 ` Palmer Dabbelt
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2019-01-10 8:33 UTC (permalink / raw)
To: Alistair Francis, qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: alistair23@gmail.com
On 2019-01-10 01:01, Alistair Francis wrote:
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> default-configs/riscv32-softmmu.mak | 1 +
> default-configs/riscv64-softmmu.mak | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/default-configs/riscv32-softmmu.mak b/default-configs/riscv32-softmmu.mak
> index dbc9398284..c9c5971409 100644
> --- a/default-configs/riscv32-softmmu.mak
> +++ b/default-configs/riscv32-softmmu.mak
> @@ -1,6 +1,7 @@
> # Default configuration for riscv-softmmu
>
> include pci.mak
> +include usb.mak
>
> CONFIG_SERIAL=y
> CONFIG_VIRTIO_MMIO=y
> diff --git a/default-configs/riscv64-softmmu.mak b/default-configs/riscv64-softmmu.mak
> index dbc9398284..c9c5971409 100644
> --- a/default-configs/riscv64-softmmu.mak
> +++ b/default-configs/riscv64-softmmu.mak
> @@ -1,6 +1,7 @@
> # Default configuration for riscv-softmmu
>
> include pci.mak
> +include usb.mak
>
> CONFIG_SERIAL=y
> CONFIG_VIRTIO_MMIO=y
Makes sense if the PCI HCDs are already working.
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] default-configs: Enable USB support for RISC-V machines
2019-01-10 0:01 [Qemu-devel] [PATCH v1 1/1] default-configs: Enable USB support for RISC-V machines Alistair Francis
2019-01-10 8:33 ` Thomas Huth
@ 2019-01-10 16:53 ` Palmer Dabbelt
2019-01-10 22:28 ` Alistair Francis
1 sibling, 1 reply; 4+ messages in thread
From: Palmer Dabbelt @ 2019-01-10 16:53 UTC (permalink / raw)
Cc: qemu-devel, qemu-riscv, alistair23, Alistair Francis
On Wed, 09 Jan 2019 16:01:34 PST (-0800), Alistair Francis wrote:
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> default-configs/riscv32-softmmu.mak | 1 +
> default-configs/riscv64-softmmu.mak | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/default-configs/riscv32-softmmu.mak b/default-configs/riscv32-softmmu.mak
> index dbc9398284..c9c5971409 100644
> --- a/default-configs/riscv32-softmmu.mak
> +++ b/default-configs/riscv32-softmmu.mak
> @@ -1,6 +1,7 @@
> # Default configuration for riscv-softmmu
>
> include pci.mak
> +include usb.mak
>
> CONFIG_SERIAL=y
> CONFIG_VIRTIO_MMIO=y
> diff --git a/default-configs/riscv64-softmmu.mak b/default-configs/riscv64-softmmu.mak
> index dbc9398284..c9c5971409 100644
> --- a/default-configs/riscv64-softmmu.mak
> +++ b/default-configs/riscv64-softmmu.mak
> @@ -1,6 +1,7 @@
> # Default configuration for riscv-softmmu
>
> include pci.mak
> +include usb.mak
>
> CONFIG_SERIAL=y
> CONFIG_VIRTIO_MMIO=y
> --
> 2.19.1
Does this work for you? I tried it out but my kernel hangs in early boot if I
enable the generic PCI controller. This is my WIP kernel so the problem is
probably on my end.
I'm trying to boot with
-device usb-ehci
-drive id=my_usb_disk,file=usbdisk.img,if=none,format=raw
-device usb-storage,drive=my_usb_dis
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] default-configs: Enable USB support for RISC-V machines
2019-01-10 16:53 ` Palmer Dabbelt
@ 2019-01-10 22:28 ` Alistair Francis
0 siblings, 0 replies; 4+ messages in thread
From: Alistair Francis @ 2019-01-10 22:28 UTC (permalink / raw)
To: Palmer Dabbelt
Cc: Alistair Francis, qemu-devel@nongnu.org Developers, qemu-riscv
On Thu, Jan 10, 2019 at 8:53 AM Palmer Dabbelt <palmer@sifive.com> wrote:
>
> On Wed, 09 Jan 2019 16:01:34 PST (-0800), Alistair Francis wrote:
> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > ---
> > default-configs/riscv32-softmmu.mak | 1 +
> > default-configs/riscv64-softmmu.mak | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/default-configs/riscv32-softmmu.mak b/default-configs/riscv32-softmmu.mak
> > index dbc9398284..c9c5971409 100644
> > --- a/default-configs/riscv32-softmmu.mak
> > +++ b/default-configs/riscv32-softmmu.mak
> > @@ -1,6 +1,7 @@
> > # Default configuration for riscv-softmmu
> >
> > include pci.mak
> > +include usb.mak
> >
> > CONFIG_SERIAL=y
> > CONFIG_VIRTIO_MMIO=y
> > diff --git a/default-configs/riscv64-softmmu.mak b/default-configs/riscv64-softmmu.mak
> > index dbc9398284..c9c5971409 100644
> > --- a/default-configs/riscv64-softmmu.mak
> > +++ b/default-configs/riscv64-softmmu.mak
> > @@ -1,6 +1,7 @@
> > # Default configuration for riscv-softmmu
> >
> > include pci.mak
> > +include usb.mak
> >
> > CONFIG_SERIAL=y
> > CONFIG_VIRTIO_MMIO=y
> > --
> > 2.19.1
>
> Does this work for you? I tried it out but my kernel hangs in early boot if I
> enable the generic PCI controller. This is my WIP kernel so the problem is
> probably on my end.
I had tested it awhile ago when I was working on the PCIe patches and
it worked for Linux.
I didn't runtime test it this time as by default there is no change it
just lets users have more boot options. Even if it doesn't work for
Linux it will be useful for other non-Linux guests.
Alistair
>
> I'm trying to boot with
>
> -device usb-ehci
> -drive id=my_usb_disk,file=usbdisk.img,if=none,format=raw
> -device usb-storage,drive=my_usb_dis
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-10 22:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-10 0:01 [Qemu-devel] [PATCH v1 1/1] default-configs: Enable USB support for RISC-V machines Alistair Francis
2019-01-10 8:33 ` Thomas Huth
2019-01-10 16:53 ` Palmer Dabbelt
2019-01-10 22:28 ` Alistair Francis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).