From: Richard Henderson <richard.henderson@linaro.org>
To: "Samuel Thibault" <samuel.thibault@gnu.org>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: qemu-devel@nongnu.org, jan.kiszka@siemens.com
Subject: Re: [Qemu-devel] [PATCH] slirp: Use lduw_be_p in slirp_input
Date: Thu, 17 Jan 2019 11:05:20 +1100 [thread overview]
Message-ID: <e31f52fc-e17a-859f-10be-1760aa1a58d7@linaro.org> (raw)
In-Reply-To: <20190116235009.tl4gcv53e62npecl@function>
On 1/17/19 10:50 AM, Samuel Thibault wrote:
> Hello,
>
> Richard Henderson, le mer. 26 déc. 2018 14:42:54 +1100, a ecrit:
>> The pointer may be unaligned, so we must use our routines for that.
>> At the same time, we might as well use the big-endian version
>> instead of ntohs.
>>
>> This fixes sparc64 host SIGBUS during pxe boot.
>
> I'm not at ease with applying this, when Marc-André is trying to make
> slirp an external library... I'd rather apply the change below, could
> somebody review it?
Fair.
> - proto = ntohs(*(uint16_t *)(pkt + 12));
> + proto = (((uint16_t) pkt[12]) << 8) + pkt[13];
This works for me too, though I note unnecessary parenthesis around the cast.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-01-17 0:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 3:42 [Qemu-devel] [PATCH] slirp: Use lduw_be_p in slirp_input Richard Henderson
2018-12-26 10:57 ` Peter Maydell
2018-12-26 11:04 ` Philippe Mathieu-Daudé
2019-01-16 23:50 ` Samuel Thibault
2019-01-17 0:05 ` Richard Henderson [this message]
2019-01-17 13:16 ` Philippe Mathieu-Daudé
2019-01-17 13:22 ` Samuel Thibault
2019-01-17 13:56 ` Peter Maydell
2019-01-18 11:25 ` Marc-André Lureau
2019-01-18 11:37 ` Marc-André Lureau
2019-01-18 11:54 ` Peter Maydell
2019-01-23 11:29 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e31f52fc-e17a-859f-10be-1760aa1a58d7@linaro.org \
--to=richard.henderson@linaro.org \
--cc=jan.kiszka@siemens.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).