From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIxWf-0000sg-Oj for qemu-devel@nongnu.org; Wed, 16 May 2018 10:35:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIxWe-0004Jm-V2 for qemu-devel@nongnu.org; Wed, 16 May 2018 10:35:33 -0400 From: Paul Durrant Date: Wed, 16 May 2018 14:34:18 +0000 Message-ID: References: <1525461967-32174-1-git-send-email-paul.durrant@citrix.com> <1525461967-32174-5-git-send-email-paul.durrant@citrix.com> <20180516143032.GI2057@perard.uk.xensource.com> In-Reply-To: <20180516143032.GI2057@perard.uk.xensource.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3 4/8] xen_backend: add an emulation of grant copy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Perard Cc: "xen-devel@lists.xenproject.org" , "qemu-block@nongnu.org" , "qemu-devel@nongnu.org" , Stefano Stabellini > -----Original Message----- > From: Anthony PERARD [mailto:anthony.perard@citrix.com] > Sent: 16 May 2018 15:31 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; qemu-block@nongnu.org; qemu- > devel@nongnu.org; Stefano Stabellini > Subject: Re: [PATCH v3 4/8] xen_backend: add an emulation of grant copy >=20 > On Fri, May 04, 2018 at 08:26:03PM +0100, Paul Durrant wrote: > > Not all Xen environments support the xengnttab_grant_copy() operation. > > E.g. where the OS is FreeBSD or Xen is older than 4.8.0. > > > > This patch introduces an emulation of that operation using > > xengnttab_map_domain_grant_refs() and memcpy() for those > environments. > > > > Signed-off-by: Paul Durrant > > --- >=20 > The patch looks ok, but since patch 1 is going to be change, this one is > going to need to be change as well. >=20 Sure. Thanks for the review. Paul > -- > Anthony PERARD