qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH 9/9] kvm: Rename irqchip_inject_ioctl to irq_set_ioctl
Date: Tue, 11 Sep 2012 18:26:37 -0300	[thread overview]
Message-ID: <e333cd694920f056573083c6d38fbdf0238c390d.1347398795.git.mtosatti@redhat.com> (raw)
In-Reply-To: <cover.1347398795.git.mtosatti@redhat.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

This variable is no longer bound to irqchip, and the IOCTL sets the IRQ
level, does not directly inject it. No functional changes.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
---
 kvm-all.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/kvm-all.c b/kvm-all.c
index a624709..b69537a 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -92,7 +92,7 @@ struct KVMState
     /* The man page (and posix) say ioctl numbers are signed int, but
      * they're not.  Linux, glibc and *BSD all treat ioctl numbers as
      * unsigned, and treating them as signed here can break things */
-    unsigned irqchip_inject_ioctl;
+    unsigned irq_set_ioctl;
 #ifdef KVM_CAP_IRQ_ROUTING
     struct kvm_irq_routing *irq_routes;
     int nr_allocated_irq_routes;
@@ -870,13 +870,13 @@ int kvm_set_irq(KVMState *s, int irq, int level)
 
     event.level = level;
     event.irq = irq;
-    ret = kvm_vm_ioctl(s, s->irqchip_inject_ioctl, &event);
+    ret = kvm_vm_ioctl(s, s->irq_set_ioctl, &event);
     if (ret < 0) {
         perror("kvm_set_irq");
         abort();
     }
 
-    return (s->irqchip_inject_ioctl == KVM_IRQ_LINE) ? 1 : event.status;
+    return (s->irq_set_ioctl == KVM_IRQ_LINE) ? 1 : event.status;
 }
 
 #ifdef KVM_CAP_IRQ_ROUTING
@@ -1385,9 +1385,9 @@ int kvm_init(void)
 
     s->intx_set_mask = kvm_check_extension(s, KVM_CAP_PCI_2_3);
 
-    s->irqchip_inject_ioctl = KVM_IRQ_LINE;
+    s->irq_set_ioctl = KVM_IRQ_LINE;
     if (kvm_check_extension(s, KVM_CAP_IRQ_INJECT_STATUS)) {
-        s->irqchip_inject_ioctl = KVM_IRQ_LINE_STATUS;
+        s->irq_set_ioctl = KVM_IRQ_LINE_STATUS;
     }
 
     ret = kvm_arch_init(s);
-- 
1.7.6.4

  parent reply	other threads:[~2012-09-11 21:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-11 21:26 [Qemu-devel] [PATCH 0/9] [PULL] qemu-kvm.git uq/master queue Marcelo Tosatti
2012-09-11 21:26 ` [Qemu-devel] [PATCH 1/9] update-linux-headers.sh: Don't hard code list of architectures Marcelo Tosatti
2012-09-11 21:26 ` [Qemu-devel] [PATCH 2/9] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create() Marcelo Tosatti
2012-09-11 21:26 ` [Qemu-devel] [PATCH 3/9] memory: Flush coalesced MMIO on selected region access Marcelo Tosatti
2012-09-11 21:26 ` [Qemu-devel] [PATCH 4/9] memory: Use transaction_begin/commit also for single-step operations Marcelo Tosatti
2012-09-11 21:26 ` [Qemu-devel] [PATCH 5/9] memory: Fold memory_region_update_topology into memory_region_transaction_commit Marcelo Tosatti
2012-09-11 21:26 ` [Qemu-devel] [PATCH 6/9] memory: Flush coalesced MMIO on mapping and state changes Marcelo Tosatti
2012-09-11 21:26 ` [Qemu-devel] [PATCH 7/9] VGA: Flush coalesced MMIO on related MMIO/PIO accesses Marcelo Tosatti
2012-09-11 21:26 ` [Qemu-devel] [PATCH 8/9] kvm: Stop flushing coalesced MMIO on vmexit Marcelo Tosatti
2012-09-11 21:26 ` Marcelo Tosatti [this message]
2012-09-17 18:20 ` [Qemu-devel] [PATCH 0/9] [PULL] qemu-kvm.git uq/master queue Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e333cd694920f056573083c6d38fbdf0238c390d.1347398795.git.mtosatti@redhat.com \
    --to=mtosatti@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).