From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, peter.maydell@linaro.org
Subject: Re: [PATCH 2/2] tcg: Zero extend 32-bit addresses for TCI
Date: Tue, 2 Dec 2025 20:58:59 +0100 [thread overview]
Message-ID: <e336abf5-589b-49b7-98b6-9206ead80197@linaro.org> (raw)
In-Reply-To: <20251202011228.503007-3-richard.henderson@linaro.org>
On 2/12/25 02:12, Richard Henderson wrote:
> For native code generation, zero-extending 32-bit addresses for
> the slow path helpers happens in tcg_out_{ld,st}_helper_args,
> but there isn't really a slow path for TCI, so that didn't happen.
>
> Make the extension for TCI explicit in the opcode stream,
> much like we already do for plugins and atomic helpers.
>
> Fixes: 24e46e6c9d9 ("accel/tcg: Widen tcg-ldst.h addresses to uint64_t")
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/tcg-op-ldst.c | 222 ++++++++++++++++++++++------------------------
> 1 file changed, 107 insertions(+), 115 deletions(-)
Was slightly simpler to review with preliminary patch 1.5 posted
(consider taking it in between). Anyway:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-12-02 19:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 1:12 [PATCH 0/2] TCI fixes Richard Henderson
2025-12-02 1:12 ` [PATCH 1/2] tcg/tci: Introduce INDEX_op_tci_qemu_{ld,st}_rrr Richard Henderson
2025-12-02 18:06 ` Philippe Mathieu-Daudé
2025-12-02 18:47 ` Philippe Mathieu-Daudé
2025-12-02 1:12 ` [PATCH 2/2] tcg: Zero extend 32-bit addresses for TCI Richard Henderson
2025-12-02 19:58 ` Philippe Mathieu-Daudé [this message]
2025-12-02 21:10 ` Richard Henderson
2025-12-02 11:55 ` [PATCH 0/2] TCI fixes Alex Bennée
2025-12-02 19:55 ` [PATCH 1.5/2] tcg: Move maybe_{extend, free}_addr64() functions around Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e336abf5-589b-49b7-98b6-9206ead80197@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).