From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A4E8C531DC for ; Tue, 20 Aug 2024 05:18:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sgHFT-0005Yz-Db; Tue, 20 Aug 2024 01:17:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgHFP-0005Wp-HZ for qemu-devel@nongnu.org; Tue, 20 Aug 2024 01:17:36 -0400 Received: from mail-oo1-xc2d.google.com ([2607:f8b0:4864:20::c2d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sgHFN-0000dP-9H for qemu-devel@nongnu.org; Tue, 20 Aug 2024 01:17:35 -0400 Received: by mail-oo1-xc2d.google.com with SMTP id 006d021491bc7-5d59e491fefso2626994eaf.1 for ; Mon, 19 Aug 2024 22:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724131051; x=1724735851; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ASsuCh4Z7nZeWtkEbIHz+hsb9X2Wxl+qjsL+S/a5ws0=; b=CJsl7ZWDiiviVGZkomf8u3PHeQfbDoWacZdynySkgM6r/EBKN4chBMlcRLc8iQqNiC w6n6IrUsgTl81Ou1TSJHYrzkQBIb2YRmDPkoiF+17DzXWVx0rcFambdbIZN3vJDHmsFv 7CDIC89N9Tt6KjTNrvZpQgCBDbJhKifkqqv9Tcj0VjE2OP2qeOuuLT5Ek8JFwRHrfuTB rOQ5JGtNGwMxDysxtxJYbbztHuNDwGRyF5LS05qYPTNW8I/lg3P3YdSNxsnskfksW+v2 42L5BJDqtQJPSyFnt7DQXgQqlRJ7XL7ICayWEP7+/MCpb96zbxpFpcQAMe/fAnedeM1T QNOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724131051; x=1724735851; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ASsuCh4Z7nZeWtkEbIHz+hsb9X2Wxl+qjsL+S/a5ws0=; b=hGteHH7mc26uFMd6h3YjhlKtaqlIveJWSsjSqt3QT4MIICRXnupCQgjFRMT5TEbDu9 h4s7bssiKCd9n0HLcS1z3nJa4CFJG83+Bl/M3tJDqrt5wqw3MpO9GFieT+scyo2yVHst ytKJflMP++ZSaQ+awOFxwgDbvJy88xe+rzgw/S4Tc8bKv8s2veGj8doEDsWQPtYSK5sj MKOqD8TWOOPKl9cIpI7XrIlRrAr2Bj0NYe9zUd5+FMlkbvRVssjev5F190RP5lcF+Uvj XGbzYR2ZLP+aWMtv48Wn5RYEbAFFAr6udgm3fACwZ3uo0kRmdzQtmISMtrKi5E0E1oMq R5Nw== X-Forwarded-Encrypted: i=1; AJvYcCXFeYfTVdG4C/h8FENvairVKyAqDZk9ZFqQuUxSHC2tuORSXKC5E9UYT9ryaKtIcr2A+CbCXMbMV1VOUVFB7ylmLyteGhs= X-Gm-Message-State: AOJu0YxPnTqcn29iYNPBssZNwUs1A7ut/l+CiYnvy91UvZpvy29YdGKk tzTNmlsotzOlgLwj0EiW2BiBCq6hyuphHKeV/+9dCzFiT4R8GA3+tK5A1QpyCH0= X-Google-Smtp-Source: AGHT+IGr7wUipPmUobgVk58sgFdGWD5Ptgjtd3DDrfhvsax0Y2kUwZ1YvKUL8qhxih3VQNvU9T2ywA== X-Received: by 2002:a05:6358:2923:b0:1a5:2f55:c46e with SMTP id e5c5f4694b2df-1b39318021dmr955027455d.9.1724131050881; Mon, 19 Aug 2024 22:17:30 -0700 (PDT) Received: from [192.168.1.113] ([203.30.3.188]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7127ae07e41sm7430193b3a.65.2024.08.19.22.17.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2024 22:17:30 -0700 (PDT) Message-ID: Date: Tue, 20 Aug 2024 15:17:22 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 02/15] target/riscv: Introduce elp state and enabling controls for zicfilp To: Deepak Gupta , qemu-riscv@nongnu.org, qemu-devel@nongnu.org Cc: palmer@dabbelt.com, Alistair.Francis@wdc.com, bmeng.cn@gmail.com, liwei1518@gmail.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, jim.shu@sifive.com, andy.chiu@sifive.com, kito.cheng@sifive.com References: <20240820000129.3522346-1-debug@rivosinc.com> <20240820000129.3522346-3-debug@rivosinc.com> Content-Language: en-US From: Richard Henderson In-Reply-To: <20240820000129.3522346-3-debug@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::c2d; envelope-from=richard.henderson@linaro.org; helo=mail-oo1-xc2d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 8/20/24 10:01, Deepak Gupta wrote: > zicfilp introduces a new state elp ("expected landing pad") in cpu. > During normal execution, elp is idle (NO_LP_EXPECTED) i.e not expecting > landing pad. On an indirect call, elp moves LP_EXPECTED. When elp is > LP_EXPECTED, only a subsquent landing pad instruction can set state back > to NO_LP_EXPECTED. On reset, elp is set to NO_LP_EXPECTED. > > zicfilp is enabled via bit2 in *envcfg CSRs. Enabling control for M-mode > is in mseccfg CSR at bit position 10. > > On trap, elp state is saved away in *status. > > Signed-off-by: Deepak Gupta > Co-developed-by: Jim Shu > Co-developed-by: Andy Chiu > Reviewed-by: Richard Henderson > --- > target/riscv/cpu.c | 3 +++ > target/riscv/cpu.h | 2 ++ > target/riscv/cpu_bits.h | 6 ++++++ > target/riscv/csr.c | 31 +++++++++++++++++++++++++++++++ > target/riscv/pmp.c | 5 +++++ > target/riscv/pmp.h | 3 ++- > 6 files changed, 49 insertions(+), 1 deletion(-) One thing missing here is to add > + /* elp state for zicfilp extension */ > + bool elp; this to the migration state, as a subsection under vmstate_riscv_cpu. Sorry I missed this before... r~