* [PATCH] configure: check for $download value properly
@ 2023-06-07 7:50 Michal Privoznik
2023-06-07 7:57 ` Philippe Mathieu-Daudé
2023-06-07 9:02 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Michal Privoznik @ 2023-06-07 7:50 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, pbonzini
If configure was invoked with --disable-download and git
submodules were not checked out a warning is produced and the
configure script fails. But the $download variable (which
reflects the enable/disable download argument) is checked for in
a weird fashion:
test -f "$download" = disabled
Drop the '-f' to check for the actual value of the variable.
Fixes: 2019cabfee0
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 8765b88e12..8a638dd82a 100755
--- a/configure
+++ b/configure
@@ -767,7 +767,7 @@ if test "$plugins" = "yes" -a "$tcg" = "disabled"; then
fi
if ! test -f "$source_path/subprojects/keycodemapdb/README" \
- && test -f "$download" = disabled
+ && test "$download" = disabled
then
echo
echo "ERROR: missing subprojects"
--
2.39.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] configure: check for $download value properly
2023-06-07 7:50 [PATCH] configure: check for $download value properly Michal Privoznik
@ 2023-06-07 7:57 ` Philippe Mathieu-Daudé
2023-06-07 9:02 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-06-07 7:57 UTC (permalink / raw)
To: Michal Privoznik, qemu-devel; +Cc: qemu-trivial, pbonzini
On 7/6/23 09:50, Michal Privoznik wrote:
> If configure was invoked with --disable-download and git
> submodules were not checked out a warning is produced and the
> configure script fails. But the $download variable (which
> reflects the enable/disable download argument) is checked for in
> a weird fashion:
>
> test -f "$download" = disabled
>
> Drop the '-f' to check for the actual value of the variable.
>
> Fixes: 2019cabfee0
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] configure: check for $download value properly
2023-06-07 7:50 [PATCH] configure: check for $download value properly Michal Privoznik
2023-06-07 7:57 ` Philippe Mathieu-Daudé
@ 2023-06-07 9:02 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2023-06-07 9:02 UTC (permalink / raw)
To: Michal Privoznik; +Cc: qemu-devel, qemu-trivial, pbonzini
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-07 9:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-07 7:50 [PATCH] configure: check for $download value properly Michal Privoznik
2023-06-07 7:57 ` Philippe Mathieu-Daudé
2023-06-07 9:02 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).