qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	"Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] Sphinx for QEMU docs? (and a doc-comment format question)
Date: Mon, 7 Nov 2016 18:50:34 +0100	[thread overview]
Message-ID: <e34d2d80-416a-1e6e-2151-4b1276e7a354@redhat.com> (raw)
In-Reply-To: <CAFEAcA-Rx3qpSnJA=k24XWqtgHwLQRDJk8-BzAz6Uqzvs=4Zww@mail.gmail.com>



On 07/11/2016 18:20, Peter Maydell wrote:
> On 7 November 2016 at 17:04, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> On 07/11/2016 16:03, Peter Maydell wrote:
>>> The overall organisation structure needs some thought --
>>> I think we should at least separate into user/ for user
>>> docs and dev/ for internals docs
> 
>> Yes, the complicated part is establishing a structure for the
>> documentation (this should be done collaboratively on the wiki, I think).
>>
>> Ultimately we should have three manuals: user, developer and hardware
>> specifications, but docs/ is currently a hodge-podge of the first two.
> 
> User and developer, sure, but what's "hardware specifications" for?

It's docs/specs.

>>> 3) the most awkward part of kernel-doc syntax is that it bakes
>>>    in the kernel's style choice of always using "struct foo"
>>>    for types -- I don't think there's any way to document
>>>    'MemoryRegion' and 'AddressSpace' without the 'struct'
>>>    coming out in the documentation output.
>>
>> I actually like having struct in the name, even if the code then
>> doesn't use it.
> 
> I think it would be good to at least be able to have '&MemoryRegion'
> in a doc comment hyperlink to the documentation of the type --
> currently that only works for '&struct MemoryRegion'.

Oh, got it now.  Yes, that would be more than just "nice to have".  What
do you think about requiring &struct in the doc comment, but then
omitting the "struct" in the generated documentation?

In any case, kerneldoc doesn't seem too rough to customize and (apart
from the latest flurry) it is touched very little in Linux.  And it also
includes other formats that Linux doesn't quite use, so perhaps Jon
Corbet would accept a patch for Texinfo.  If our changes were limited to
a bunch of changes $type_* at the top, it would be pretty good already.

Paolo

> Also it seems a bit odd for our coding style and documentation
> style to be divergent, since it suggests to new developers
> that they should be using 'struct' in their code.
> 
> thanks
> -- PMM
> 

  reply	other threads:[~2016-11-07 17:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-05 18:42 [Qemu-devel] Sphinx for QEMU docs? (and a doc-comment format question) Peter Maydell
2016-11-07  9:35 ` Daniel P. Berrange
2016-11-07 13:30 ` Stefan Hajnoczi
2016-11-07 13:41   ` Daniel P. Berrange
2016-11-07 13:49   ` Peter Maydell
2016-11-07 22:52   ` John Snow
2016-11-08 16:20     ` Stefan Hajnoczi
2016-11-08 16:24       ` John Snow
2016-11-09 11:32         ` Stefan Hajnoczi
2016-11-10  3:39           ` Fam Zheng
2016-11-10  9:55             ` Stefan Hajnoczi
2016-11-10 10:08             ` Paolo Bonzini
2016-11-10 10:55               ` Daniel P. Berrange
2016-11-08 23:56   ` Paolo Bonzini
2016-11-07 15:03 ` Peter Maydell
2016-11-07 17:04   ` Paolo Bonzini
2016-11-07 17:20     ` Peter Maydell
2016-11-07 17:50       ` Paolo Bonzini [this message]
2016-11-07 18:23         ` Peter Maydell
2016-11-07 19:43           ` Paolo Bonzini
2016-11-07 20:36             ` Peter Maydell
2016-11-08  5:02   ` Emilio G. Cota
2017-01-05 16:47   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e34d2d80-416a-1e6e-2151-4b1276e7a354@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=berrange@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).