From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FD3BC4346E for ; Thu, 24 Sep 2020 08:33:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 940D9206FC for ; Thu, 24 Sep 2020 08:33:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dBAUaYD3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 940D9206FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLMge-0004Vt-MB for qemu-devel@archiver.kernel.org; Thu, 24 Sep 2020 04:33:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLMf2-0003VF-31 for qemu-devel@nongnu.org; Thu, 24 Sep 2020 04:31:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57676) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kLMf0-0007a0-C4 for qemu-devel@nongnu.org; Thu, 24 Sep 2020 04:31:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600936285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PRyhVabqlNNROwRo/eS70C6s1fUNr4aYAUiGISFNaoc=; b=dBAUaYD3ShULO+bHxWB64l99PEFygAUbbWKzHebC4Le/PrmAHJUCqlmupSN8K0QGf9ieR5 wNgAg004RvBcdP9VOVi5xUdsljjnJRF9gy1yClF22pYMv5OPm42CSS8iVChu1YbeXpoGwf o6EQsMvHhq+CsmOiQUFG4gb5b/4KqTg= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-583-TNfRqirjM7-xGOKMlyyIxA-1; Thu, 24 Sep 2020 04:31:24 -0400 X-MC-Unique: TNfRqirjM7-xGOKMlyyIxA-1 Received: by mail-wm1-f71.google.com with SMTP id m19so947233wmg.6 for ; Thu, 24 Sep 2020 01:31:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=PRyhVabqlNNROwRo/eS70C6s1fUNr4aYAUiGISFNaoc=; b=e+IjHTZAuln9y3vQKIlGKhuDs8CfbNyswLhXBBiusEIpDzOyRhxyDwG7W5c6Ipp9Jf geFqVpEiv8oIAPWUdk0sEfJ8DEke1vuxeZArUTN4yrEd89T25hoUXVereBow7jyFsr5S KuWzaXCfpu0ffYnPTzhMPhUWpzCQzidzsYFy0JRcA4XP8ElsoaedC8ND//OqnkmkliZo M/zrSCTtn5f1aiCNCTRHLfMNDll+hobiStrHwkgDSuahc+sK8WMcDrsRkL4n1J037tb1 NLVmkq4HEhAJqxo27fpw0p0wbVIsTu/eFfccpRvM549/isiQP9nfaEPvTAQjYpnaSpn8 2i5Q== X-Gm-Message-State: AOAM530bfRHgJAE8iz5YeT4EFzOslcJNYF9zBSwMwztKE2o368dzrpxB kHLQPz4Kg+vdLcQH9Y7aUJZvBQKACBQcIHFwU5wApQ+uWtZfuit5v+ybKikzfbLlocBhmncTjtq g5umGJ9jOkeDAlaE= X-Received: by 2002:a1c:7912:: with SMTP id l18mr3483936wme.124.1600936282827; Thu, 24 Sep 2020 01:31:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzL6HlalUe2G+NixVFYukTwT9s4VmzVcivoigo+BOF0io2vJ5UsEIYEMnbOF8csmWa1ywBhtQ== X-Received: by 2002:a1c:7912:: with SMTP id l18mr3483904wme.124.1600936282586; Thu, 24 Sep 2020 01:31:22 -0700 (PDT) Received: from [192.168.1.34] (234.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.234]) by smtp.gmail.com with ESMTPSA id n2sm2721284wma.29.2020.09.24.01.31.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Sep 2020 01:31:22 -0700 (PDT) Subject: Re: [PATCH v8 6/7] block: drop bdrv_prwv To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org References: <20200915164411.20590-1-vsementsov@virtuozzo.com> <20200915164411.20590-7-vsementsov@virtuozzo.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: Date: Thu, 24 Sep 2020 10:31:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200915164411.20590-7-vsementsov@virtuozzo.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 23:02:20 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.228, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, ehabkost@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, crosa@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/15/20 6:44 PM, Vladimir Sementsov-Ogievskiy wrote: > Now that we are not maintaining boilerplate code for coroutine > wrappers, there is no more sense in keeping the extra indirection layer > of bdrv_prwv(). Let's drop it and instead generate pure bdrv_preadv() > and bdrv_pwritev(). > > Currently, bdrv_pwritev() and bdrv_preadv() are returning bytes on > success, auto generated functions will instead return zero, as their > _co_ prototype. Still, it's simple to make the conversion safe: the > only external user of bdrv_pwritev() is test-bdrv-drain, and it is > comfortable enough with bdrv_co_pwritev() instead. So prototypes are > moved to local block/coroutines.h. Next, the only internal use is > bdrv_pread() and bdrv_pwrite(), which are modified to return bytes on > success. > > Of course, it would be great to convert bdrv_pread() and bdrv_pwrite() > to return 0 on success. But this requires audit (and probably > conversion) of all their users, let's leave it for another day > refactoring. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Eric Blake > --- > block/coroutines.h | 10 ++++----- > include/block/block.h | 2 -- > block/io.c | 49 ++++++++--------------------------------- > tests/test-bdrv-drain.c | 2 +- > 4 files changed, 15 insertions(+), 48 deletions(-) Reviewed-by: Philippe Mathieu-Daudé