From: Cole Robinson <crobinso@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Cole Robinson" <crobinso@redhat.com>
Subject: [Qemu-devel] [PATCH 2/3] ui: spice: Exit if gl=on EGL init fails
Date: Wed, 18 May 2016 12:40:50 -0400 [thread overview]
Message-ID: <e3789e35b16f9e3cc6f2652f91c52d88ba6d6936.1463588606.git.crobinso@redhat.com> (raw)
In-Reply-To: <cover.1463588606.git.crobinso@redhat.com>
In-Reply-To: <cover.1463588606.git.crobinso@redhat.com>
The user explicitly requested spice GL, so if we know it isn't
going to work we should exit
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
For example, trying to use spice GL with libvirt qemu:///system will
fail here, since the the VM will lack permissions to access
/dev/dir/renderD*
ui/spice-core.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 61db3c1..da05054 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -833,9 +833,11 @@ void qemu_spice_init(void)
"incompatible with -spice port/tls-port");
exit(1);
}
- if (egl_rendernode_init() == 0) {
- display_opengl = 1;
+ if (egl_rendernode_init() != 0) {
+ error_report("Failed to initialize EGL render node for SPICE GL");
+ exit(1);
}
+ display_opengl = 1;
}
#endif
}
--
2.7.4
next prev parent reply other threads:[~2016-05-18 16:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 16:40 [Qemu-devel] [PATCH 0/3] ui: improve feedback if gl setup fails Cole Robinson
2016-05-18 16:40 ` [Qemu-devel] [PATCH 1/3] ui: egl: Replace fprintf with error_report Cole Robinson
2016-05-18 16:50 ` Eric Blake
2016-05-19 15:19 ` Marc-André Lureau
2016-05-18 16:40 ` Cole Robinson [this message]
2016-05-19 15:19 ` [Qemu-devel] [PATCH 2/3] ui: spice: Exit if gl=on EGL init fails Marc-André Lureau
2016-05-18 16:40 ` [Qemu-devel] [PATCH 3/3] virtio-gpu: Warn if UI config will disable virgl Cole Robinson
2016-05-19 15:19 ` Marc-André Lureau
2016-05-20 5:53 ` Gerd Hoffmann
2016-05-20 14:49 ` Cole Robinson
2016-05-23 7:34 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3789e35b16f9e3cc6f2652f91c52d88ba6d6936.1463588606.git.crobinso@redhat.com \
--to=crobinso@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).