From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C7F5C28B20 for ; Wed, 2 Apr 2025 09:52:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tzukw-0005qR-7J; Wed, 02 Apr 2025 05:51:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tzuku-0005q9-Cf for qemu-devel@nongnu.org; Wed, 02 Apr 2025 05:51:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tzuks-00034X-N2 for qemu-devel@nongnu.org; Wed, 02 Apr 2025 05:51:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743587488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yzYFGiwsoy0wIOpN9T22CBNGfXfZL5LyN4Od33ySCv8=; b=RYTVFykTI0QfHkmVMRA6TvqkCtP3QnsiiQiqnNagpEecHktXonbWl2be8EBJ/JruXAqIqj Xq+kGnem3qHOjCiOPWFhaiXU8W0vnlsO7/0Oka4qCOV71lOCNK9qSi5vW6Dzk+E4NC2AIz uqJfNNN/Lzg6FFd7R/svfo7RWSAGWqY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-RKBCMbCeMIeDJLh6p0CgCg-1; Wed, 02 Apr 2025 05:51:26 -0400 X-MC-Unique: RKBCMbCeMIeDJLh6p0CgCg-1 X-Mimecast-MFC-AGG-ID: RKBCMbCeMIeDJLh6p0CgCg_1743587485 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43cf446681cso40326285e9.1 for ; Wed, 02 Apr 2025 02:51:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743587485; x=1744192285; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yzYFGiwsoy0wIOpN9T22CBNGfXfZL5LyN4Od33ySCv8=; b=rtK8NcmMgcb2ywJjN8XzvjxVvLOXJEwjDDImx4DXsos+haxzocjf/FwO2K8155iReZ Z53LI9fG6Kvk+4BxcRs5QdzacJlxN5/V76ULwUb+9eLM8JQYIFrQDVziE5CVdgbqaXYK JcqZmbyFOtJsTEF6VH/wTR91hIcsOhdsrL8IpAwv+5EniDMOLqy1r8ukNEbdoZiYSIr2 sfMykyMjW7T6pGFnVovQ+lynLLJLm9BmR1tXcRjjqbngye0wqRXopF2SOB8i8kimq5wC g1mL4UiMnkZMUfs/Lj53OQqxQATagVSEq9+WNxhxoX7LHJM5BaKxJ9pPWuaoQx2yKu/D LmvA== X-Forwarded-Encrypted: i=1; AJvYcCW9ctOSmQrhjintGmpHpnBVp6Ow5a2LFSHzsnIZksvMKLgwq6yZzkoGBB75leKIszHFYpbWTauyqumt@nongnu.org X-Gm-Message-State: AOJu0YyKHnHjG3seyw8c0p/ezAHgaVwNZgxz5tUsUI2S5ECvkcEGV3S7 5uAz6BFyC/9CuBhYpiCPNEYylBaJlSbzS0r36e5mttrM6XCnhbgYnLH9nf+BwKkYR3U+UJJ/tZq QYpX3COjThAoiI2U9Oz/XhvgZUWfFrWivVWK9ACGCOMihpYtmHo0r X-Gm-Gg: ASbGncvlbGOEQf18e4iJ7mtnwCSal+Ff6KKkK1/sU8cNbulem3lnQSoYRO05rtS7Eva D/5xgHItrGH8/LUy/glaLVop97rsk7/sBUF3FI4esuCcagNi09awkc+afbnR1sVssakA3tH4jIj gTLRoCQ7lOub8IKf+68A+D6wqYGvuDM35c4GGtPx1zRdIjZhAKVce6+cT+LMosxAMjPj7BE68P4 8AHPRtChTqLMxO9uOX4sRwDxxBtk8zgjTD0CjMho8sext2lKRNlT/ixWlY/g/tayoIsRZ4wsEym xfJWjUf1VinN8TM6fTDqknVm19yudVsZy+4h/Xcg7oTLBG6J8L7Xmw== X-Received: by 2002:a5d:47c5:0:b0:391:2d8f:dd59 with SMTP id ffacd0b85a97d-39c120e1665mr15314796f8f.24.1743587484970; Wed, 02 Apr 2025 02:51:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFg65TWSctuslik9jTws2Pe/V6XhamtsTku6v1kiiBkm/inSFs1Gf3veawEYV2aDzX3BCfu1w== X-Received: by 2002:a5d:47c5:0:b0:391:2d8f:dd59 with SMTP id ffacd0b85a97d-39c120e1665mr15314771f8f.24.1743587484586; Wed, 02 Apr 2025 02:51:24 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:9db0:474c:ff43:9f5c? ([2a01:e0a:280:24f0:9db0:474c:ff43:9f5c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c0b65b985sm16565839f8f.12.2025.04.02.02.51.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Apr 2025 02:51:24 -0700 (PDT) Message-ID: Date: Wed, 2 Apr 2025 11:51:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] vfio/migration: Add also max in-flight VFIO device state buffers size limit To: "Maciej S. Szmigiero" Cc: Alex Williamson , Eric Blake , Peter Xu , Fabiano Rosas , Markus Armbruster , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Avihai Horon , Joao Martins , qemu-devel@nongnu.org References: <2b2469939198c2f31dba33b284576d2df22697b7.1741344976.git.maciej.szmigiero@oracle.com> <3826d47f-d79b-4db2-9719-35f48f582bf0@maciej.szmigiero.name> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.997, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hello Maciej, On 4/1/25 14:26, Maciej S. Szmigiero wrote: > On 11.03.2025 14:04, Cédric Le Goater wrote: >> On 3/7/25 14:45, Maciej S. Szmigiero wrote: >>> On 7.03.2025 13:03, Cédric Le Goater wrote: >>>> On 3/7/25 11:57, Maciej S. Szmigiero wrote: >>>>> From: "Maciej S. Szmigiero" >>>>> >>>>> There's already a max in-flight VFIO device state buffers *count* limit, >>>> >>>> no. there isn't. Do we need both ? >>> >>> This is on a top of the remaining patches (x-migration-load-config-after-iter >>> and x-migration-max-queued-buffers) - I thought we were supposed to work >>> on these after the main series was merged as they are relatively non-critical. >> >> yes. we don't need both count and size limits though, a size limit is enough. >> >>> I would also give x-migration-load-config-after-iter priority over >>> x-migration-max-queued-buffers{,-size} as the former is correctness fix >>> while the later are just additional functionalities. >> >> ok. I have kept both patches in my tree with the doc updates. >> > > I don't see the x-migration-load-config-after-iter patch in upstream QEMU > anywhere. > That's a bit concerning since it's a correctness fix - without it the > multifd VFIO migration on ARM64 can fail. > > The existing patch still applies, but requires changing > "#if defined(TARGET_ARM)" to "strcmp(target_name(), "aarch64") == 0" due to > recent commit 5731baee6c3c ("hw/vfio: Compile some common objects once"). > > I can submit an updated patch if you like. It is a bit early. Let's wait for the spring cleanup to be applied first. I am waiting for more feedback from Avihai and Joao. It should not be long. Thanks, C.