From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58C53C4361A for ; Sat, 5 Dec 2020 12:50:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E87DB22DFA for ; Sat, 5 Dec 2020 12:50:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E87DB22DFA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klX0y-0002uU-Vn for qemu-devel@archiver.kernel.org; Sat, 05 Dec 2020 07:50:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33470) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klWy1-0000c5-SL for qemu-devel@nongnu.org; Sat, 05 Dec 2020 07:47:13 -0500 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]:38593) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klWy0-0005h8-Cr for qemu-devel@nongnu.org; Sat, 05 Dec 2020 07:47:13 -0500 Received: by mail-ot1-x344.google.com with SMTP id b62so8011885otc.5 for ; Sat, 05 Dec 2020 04:47:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=y0i4sd4jyRSMJOAt5fSmRA1kyI+sbU2giBDSkTi2/ts=; b=i9BU3SGcy12FOB11lRoJFhkQUE93GdQ//gjt8erv9oZc6tUrvPur37utWiyytd08jz Nq6TrRDL0pwXkidrAPn43Xbygy8MeXWL88ulPXmHc/lddRIy7tP6xOphKkBiVptD4x0M MsFUoLSnImRXPDBWnxkgMaitqWOtvjriuVnpS4N7xch1AT8vBQp6aMwKEQax+H2uzDN1 4GthyjxqtuVLtwVgVbeLrqbtxTz3GSckacr53m7q5/W2Uv/bkf8p3sil4/QuzT7TNa1d Exf5MfxBFniuW/vPN0ggoBIWnzRnX4dIO3rqDyjM1vHqELwh1DL22uML/yWE2IwSX9mW 01ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=y0i4sd4jyRSMJOAt5fSmRA1kyI+sbU2giBDSkTi2/ts=; b=kdVFr1ct2datR3JQBCScm32AUEG2iSNstt+Fx7hP8sMx/psUv4Zotf7XZfbwU3CHJ9 iaNjS7vZkmWk9WUaCtAi1J9EDPdhsiDXu9q1P45ItU0UVfNOIpwobvI0S/uk0R/KEwhz wywe5RHggCaS+qXgLYr/xjJhZH8kbTdbsUGaEUSOIQK6L5moqVIiTzDb1oxXpW3dP1a/ 8ftuMjAt4deLACMJbJoWD2qGDVTgjpgE8cXvzVJDIuum7XiITJY3j/SHWPjDZuinRf/a oM2oMGYX5jOXQwp8RHJLDSSaUO6IaH+4kZNNOiqpYiKQHMQqjhjugCW6wnYPriGR6U4f IVHw== X-Gm-Message-State: AOAM530jI3VnXe55rOCp6v1Ffr2zs5c/MPoce2uhd1QOT4SJrlHKGoUP 0192zassiNJpGno4f3CrksiMoQ== X-Google-Smtp-Source: ABdhPJxXZIA5RTvskfQHPX8ne7VlWQbWXqHjW+eeLH2c4O2N/w/8RTSgYvrNrZyMQ3FUB5pJOv1PJA== X-Received: by 2002:a9d:b8e:: with SMTP id 14mr4959869oth.316.1607172431238; Sat, 05 Dec 2020 04:47:11 -0800 (PST) Received: from [172.24.51.127] (168.189-204-159.bestelclientes.com.mx. [189.204.159.168]) by smtp.gmail.com with ESMTPSA id q127sm775359oia.18.2020.12.05.04.47.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Dec 2020 04:47:10 -0800 (PST) Subject: Re: [PATCH 2/5] target/mips: Introduce ase_mt_available() helper To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Jiaxun Yang , Huacai Chen , qemu-devel@nongnu.org References: <20201204222622.2743175-1-f4bug@amsat.org> <20201204222622.2743175-3-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Sat, 5 Dec 2020 06:47:08 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201204222622.2743175-3-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::344; envelope-from=richard.henderson@linaro.org; helo=mail-ot1-x344.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/4/20 4:26 PM, Philippe Mathieu-Daudé wrote: > Instead of accessing CP0_Config3 directly and checking > the 'Multi-Threading Present' bit, introduce an helper > to simplify code review. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/cpu.h | 7 +++++++ > hw/mips/cps.c | 3 +-- > target/mips/cp0_helper.c | 2 +- > target/mips/cpu.c | 2 +- > target/mips/helper.c | 2 +- > target/mips/translate.c | 2 +- > 6 files changed, 12 insertions(+), 6 deletions(-) Reviewed-by: Richard Henderson r~