From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 268F6C433DF for ; Wed, 12 Aug 2020 17:50:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E323E2076C for ; Wed, 12 Aug 2020 17:50:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XXx1tdhi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E323E2076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5ut4-0007gq-5j for qemu-devel@archiver.kernel.org; Wed, 12 Aug 2020 13:50:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5urM-0006Ho-9a for qemu-devel@nongnu.org; Wed, 12 Aug 2020 13:48:20 -0400 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:43822) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5urK-0004cS-Kv for qemu-devel@nongnu.org; Wed, 12 Aug 2020 13:48:20 -0400 Received: by mail-pf1-x434.google.com with SMTP id y206so1374470pfb.10 for ; Wed, 12 Aug 2020 10:48:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/D9CsbLRGlgR3+bpTAcYqbtG1Xp24A8kPxeMyv55O8I=; b=XXx1tdhiUd2M/rp4yUCaZnxIgb5m73w9u7/1yuYjF+8uMZ/9aJqHiohmLeScTWMkIF ajP/IlVZJyWUXDSEmsdzFUwIYaKs05p7CvywULLqcQd9P/g7O4rRnn+Di61WgIyDCxHX KL2ze7WpwXuvmf/is5v+WIhRs/OLDzo18ZAyaaj6TogPPdTRiFZJI2mP5CqAv6gWRG95 rgoxYjto+miscIVxgUiflLiHRvSh12br8I2s1TXkLNBGMDaEA1OclgHVmrsU01vaGkPZ n5tuMMCyfI2u0haSiYeceWDf8BtM2hHBUn5SYKonejGXL52dXjHjOtzuBa0TWt1btXtY Nd5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/D9CsbLRGlgR3+bpTAcYqbtG1Xp24A8kPxeMyv55O8I=; b=szKLXLt6vC8y4Ybh6DxUDiZCbifi8qqVGkNQQZMKDuOLc47LuiXt76/gCVkTML41sV p0+RbZE13DiGySCiGSQIMRZWXQF59MACq5yuVWdcCtRMlGTCbWPkEZNDcX3sAMNM4qAq iqKhdm3JspEKaq++0RhoOSFheh7+ODsfp5nHIeuhF4PxW4LYUA/wzSI5NwEoHToGiC0A JhOraIIwtbxwlNkFG8NMu3yKmanzHRpKMtZAtQ1eoUu2o5s9zkzholPDDkymibVTkRzo 1Q3CFR7PxTYKaYtgxMK7gCTQNmzbGx0lkQDIEqhqLF8VHjZ1rrw3itSk3MAK9aVtVxuZ 6WZg== X-Gm-Message-State: AOAM5311lnCy438bC0tlEdZi32qGFTRwFJ6KuBEbUZb0ZsftrZVqanrR rqIA93kVXVnFQ1qH7trnAm8JRA== X-Google-Smtp-Source: ABdhPJz+tccEDGK3D0wrHhXAc37zroiS/qZCLPVTj7AJRXQGxTcpoVRqEdBgU/mHWdpt81lcNGpl+g== X-Received: by 2002:a63:d612:: with SMTP id q18mr267547pgg.292.1597254497416; Wed, 12 Aug 2020 10:48:17 -0700 (PDT) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id gz7sm2686482pjb.45.2020.08.12.10.48.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Aug 2020 10:48:16 -0700 (PDT) Subject: Re: [PATCH-for-5.2 2/2] hw/core/sysbus: Assert memory region index is in range To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200806130945.21629-1-f4bug@amsat.org> <20200806130945.21629-3-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Wed, 12 Aug 2020 10:48:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200806130945.21629-3-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x434.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Eduardo Habkost , qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/6/20 6:09 AM, Philippe Mathieu-Daudé wrote: > Devices incorrectly modelled might use invalid index while > calling sysbus_mmio_get_region(), leading to OOB access. > Help developers by asserting the index is in range. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/core/sysbus.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson r~