From: Thomas Huth <thuth@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: berrange@redhat.com, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>
Subject: Re: [RFC PATCH] tests/docker: move alpine from edge to tagged release
Date: Thu, 29 Sep 2022 13:06:25 +0200 [thread overview]
Message-ID: <e3c254d1-ee06-4b05-6521-2bf94dd2e22e@redhat.com> (raw)
In-Reply-To: <20220929105548.542555-1-alex.bennee@linaro.org>
On 29/09/2022 12.55, Alex Bennée wrote:
> Tracking alpine-edge like debian-sid is a moving target. Usually such
> rolling releases are marked as "allow_failure: true" in our CI.
> However as alpine presents a musl based and provides useful extra
"a musl based distro" ?
> coverage lets track a release branch instead to avoid random
> breakages.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/docker/dockerfiles/alpine.docker | 4 ++--
> tests/lcitool/refresh | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/docker/dockerfiles/alpine.docker b/tests/docker/dockerfiles/alpine.docker
> index 7d6e95275a..9b7541261a 100644
> --- a/tests/docker/dockerfiles/alpine.docker
> +++ b/tests/docker/dockerfiles/alpine.docker
> @@ -1,10 +1,10 @@
> # THIS FILE WAS AUTO-GENERATED
> #
> -# $ lcitool dockerfile --layers all alpine-edge qemu
> +# $ lcitool dockerfile --layers all alpine-316 qemu
> #
> # https://gitlab.com/libvirt/libvirt-ci
>
> -FROM docker.io/library/alpine:edge
> +FROM docker.io/library/alpine:3.16
>
> RUN apk update && \
> apk upgrade && \
> diff --git a/tests/lcitool/refresh b/tests/lcitool/refresh
> index 783497a989..ce0b24c0b1 100755
> --- a/tests/lcitool/refresh
> +++ b/tests/lcitool/refresh
> @@ -107,7 +107,7 @@ try:
> #
> # Standard native builds
> #
> - generate_dockerfile("alpine", "alpine-edge")
> + generate_dockerfile("alpine", "alpine-316")
> generate_dockerfile("centos8", "centos-stream-8")
> generate_dockerfile("debian-amd64", "debian-11",
> trailer="".join(debian11_extras))
Sounds like a good idea.
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2022-09-29 11:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 10:55 [RFC PATCH] tests/docker: move alpine from edge to tagged release Alex Bennée
2022-09-29 11:06 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3c254d1-ee06-4b05-6521-2bf94dd2e22e@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).