From: Richard Henderson <richard.henderson@linaro.org>
To: "Helge Deller" <deller@gmx.de>,
"Laurent Vivier" <laurent@vivier.eu>,
qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH v3] linux-user: Add guest memory layout to exception dump
Date: Tue, 25 Oct 2022 12:25:55 +1000 [thread overview]
Message-ID: <e3d81adf-d47f-98ad-9f41-f55c1f73e9c8@linaro.org> (raw)
In-Reply-To: <07dbe94d-c215-2be3-1769-4f2a8290573e@gmx.de>
On 10/25/22 11:57, Helge Deller wrote:
> On 10/25/22 00:35, Richard Henderson wrote:
>> On 10/25/22 06:18, Helge Deller wrote:
>>> When the emulation stops with a hard exception it's very useful for
>>> debugging purposes to dump the current guest memory layout (for an
>>> example see /proc/self/maps) beside the CPU registers.
>>>
>>> The open_self_maps() function provides such a memory dump, but since
>>> it's located in the syscall.c file, various changes (add #includes, make
>>> this function externally visible, ...) are needed to be able to call it
>>> from the existing EXCP_DUMP() macro.
>>
>> /proc/self/maps has all of the qemu mappings in it as well.
>
> I'm not quite sure on how to understand your comments above.
> Just comments or NAK to the patch?
A question.
Did you really wanted the host mappings included?
If so, fine.
If not, pointing out there's a better function to use.
r~
next prev parent reply other threads:[~2022-10-25 2:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 20:18 [PATCH v3] linux-user: Add guest memory layout to exception dump Helge Deller
2022-10-24 20:29 ` Laurent Vivier
2022-10-24 22:35 ` Richard Henderson
2022-10-25 1:57 ` Helge Deller
2022-10-25 2:25 ` Richard Henderson [this message]
2022-10-25 2:51 ` Helge Deller
2022-10-25 5:24 ` Richard Henderson
2022-10-25 5:28 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3d81adf-d47f-98ad-9f41-f55c1f73e9c8@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).