From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: "Markus Armbruster" <armbru@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH v2] spice: move client_migrate_info command to ui/
Date: Fri, 21 Apr 2023 08:30:32 +0200 [thread overview]
Message-ID: <e428d658-d30c-cc80-0f2a-29e7dbd82a95@linaro.org> (raw)
In-Reply-To: <20230420123711.26640-1-quintela@redhat.com>
On 20/4/23 14:37, Juan Quintela wrote:
> It has nothing to do with migration, except for the "migrate" in the
> name of the command. Move it with the rest of the ui commands.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> ---
>
> I would claim that it should be only compiled with CONFIG_SPICE, but
> I left that to spice maintainers.
>
> Gerd, what do you think?
> Should I take this patch over my tree?
>
> Based-on: Message-Id: <20230420121038.25167-1-quintela@redhat.com>
> [PATCH v3] migration: move migration_global_dump() to migration-hmp-cmds.c
>
> ---
> qapi/migration.json | 28 ----------------------------
> qapi/ui.json | 28 ++++++++++++++++++++++++++++
> migration/migration-hmp-cmds.c | 18 ------------------
> migration/migration.c | 30 ------------------------------
> ui/ui-hmp-cmds.c | 17 +++++++++++++++++
> ui/ui-qmp-cmds.c | 29 +++++++++++++++++++++++++++++
> 6 files changed, 74 insertions(+), 76 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-04-21 6:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 12:37 [PATCH v2] spice: move client_migrate_info command to ui/ Juan Quintela
2023-04-21 6:30 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e428d658-d30c-cc80-0f2a-29e7dbd82a95@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).