qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Zhao Liu <zhao1.liu@intel.com>
Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org
Subject: Re: [PATCH] i386: Fix the missing Rust HPET configuration option
Date: Tue, 18 Feb 2025 09:09:28 +0100	[thread overview]
Message-ID: <e43f8169-4017-4a3a-9274-4daf9919c290@redhat.com> (raw)
In-Reply-To: <20250217154416.3144571-1-zhao1.liu@intel.com>

On 2/17/25 16:44, Zhao Liu wrote:
> The configuration option of Rust HPET is missing, so that PC machine
> can't boot with "hpet=on" when QEMU Rust support is enabled.
> 
> Add the Rust HPET configuration option.
> 
> Fixes: d128c341a744 ("i386: enable rust hpet for pc when rust is enabled")
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
>   hw/timer/Kconfig | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/hw/timer/Kconfig b/hw/timer/Kconfig
> index 9ac008453408..c051597180f4 100644
> --- a/hw/timer/Kconfig
> +++ b/hw/timer/Kconfig
> @@ -13,6 +13,10 @@ config HPET
>       bool
>       default y if PC && !HAVE_RUST
>   
> +config X_HPET_RUST
> +    bool
> +    default y if PC && HAVE_RUST
> +
>   config I8254
>       bool
>       depends on ISA_BUS

The config item is already declared in rust/hw/timer/Kconfig, so it's 
enough to do

diff --git b/rust/hw/timer/Kconfig a/rust/hw/timer/Kconfig
index afd98033503..42e421317a5 100644
--- b/rust/hw/timer/Kconfig
+++ a/rust/hw/timer/Kconfig
@@ -1,2 +1,3 @@
  config X_HPET_RUST
      bool
+    default y if PC && HAVE_RUST

I applied it with your commit message.

Paolo



  reply	other threads:[~2025-02-18  8:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-17 15:44 [PATCH] i386: Fix the missing Rust HPET configuration option Zhao Liu
2025-02-18  8:09 ` Paolo Bonzini [this message]
2025-02-18  8:40   ` Zhao Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e43f8169-4017-4a3a-9274-4daf9919c290@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-rust@nongnu.org \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).