From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Cédric Le Goater" <clg@kaod.org>,
"David Gibson" <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Andrea Bolognani <abologna@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] ppc/pnv: Add model for Power8 PHB3 PCIe Host bridge
Date: Fri, 27 Jul 2018 18:18:51 +1000 [thread overview]
Message-ID: <e444331077031e04ff2037732e50007016af5bc6.camel@kernel.crashing.org> (raw)
In-Reply-To: <25b9402d-d3e3-ca43-7f57-698650f0681f@kaod.org>
On Fri, 2018-07-27 at 09:16 +0200, Cédric Le Goater wrote:
> > I'd have to remember how PQ works on P8 ... my gut feeling is that we
> > should resend if P=1 but I'm no 100% certain.
>
> This is not exactly what the code does. To force a resend, it ignores
> P but if Q=1, it bails out without doing anything, like a normal trigger
> would do. So I think that in the resend case we should ignore Q as well.
Not too sure. We might need to swallow the resend if PQ became 01.
I don't know for sure what the HW does. Does it unconditionally resend
or does it re-evaluate the priority etc... it's unclear to me.
But yes, we should still resend if PQ=11
Cheers,
Ben.
next prev parent reply other threads:[~2018-07-27 8:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 8:36 [Qemu-devel] [PATCH v2 0/2] ppc/pnv: Add model for Power8 PHB3 PCIe Host bridge Cédric Le Goater
2018-06-28 8:36 ` [Qemu-devel] [PATCH v2 1/2] " Cédric Le Goater
2018-07-09 7:22 ` Cédric Le Goater
2018-07-18 6:13 ` David Gibson
2018-07-18 6:12 ` David Gibson
2018-07-18 8:03 ` Benjamin Herrenschmidt
2018-07-23 4:16 ` David Gibson
2018-07-23 23:55 ` Benjamin Herrenschmidt
2018-07-24 2:14 ` David Gibson
2018-07-24 3:49 ` Benjamin Herrenschmidt
2018-07-24 4:10 ` David Gibson
2018-07-23 21:35 ` Cédric Le Goater
2018-07-23 21:37 ` Cédric Le Goater
2018-07-24 1:29 ` David Gibson
2018-07-23 21:38 ` Cédric Le Goater
2018-07-24 12:18 ` Cédric Le Goater
2018-07-27 5:32 ` David Gibson
2018-07-27 7:33 ` Cédric Le Goater
2018-07-27 8:08 ` Benjamin Herrenschmidt
2018-07-27 8:25 ` Cédric Le Goater
2018-07-27 8:43 ` Benjamin Herrenschmidt
2018-07-27 9:19 ` Cédric Le Goater
2018-07-30 8:56 ` Cédric Le Goater
2018-07-26 9:03 ` Cédric Le Goater
2018-07-26 22:36 ` Benjamin Herrenschmidt
2018-07-27 7:16 ` Cédric Le Goater
2018-07-27 8:18 ` Benjamin Herrenschmidt [this message]
2018-06-28 8:36 ` [Qemu-devel] [PATCH v2 2/2] ppc/pnv: make the PHB3 devices user creatable Cédric Le Goater
2018-07-01 18:33 ` [Qemu-devel] [PATCH v2 0/2] ppc/pnv: Add model for Power8 PHB3 PCIe Host bridge no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e444331077031e04ff2037732e50007016af5bc6.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=abologna@redhat.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).