From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: John Snow <jsnow@redhat.com>, Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH] hw/ide: Remove last two uses of ide/internal.h outside of hw/ide
Date: Fri, 23 Feb 2024 17:59:33 +0100 [thread overview]
Message-ID: <e44fde31-ca7f-4b79-87ab-bf94881d1be7@linaro.org> (raw)
In-Reply-To: <20240223142633.933694E6004@zero.eik.bme.hu>
On 23/2/24 15:26, BALATON Zoltan wrote:
> Remove last two includes of hw/ide/intarnal.h outside of hw/ide and
> replace them with newly added public header to allow moving internal.h
> into hw/ide to really stop exposing it.
>
> Fixes: a11f439a0e (hw/ide: Stop exposing internal.h to non-IDE files)
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/arm/sbsa-ref.c | 2 +-
> {include/hw => hw}/ide/internal.h | 0
> include/hw/misc/macio/macio.h | 2 +-
> 3 files changed, 2 insertions(+), 2 deletions(-)
> rename {include/hw => hw}/ide/internal.h (100%)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-02-23 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 14:26 [PATCH] hw/ide: Remove last two uses of ide/internal.h outside of hw/ide BALATON Zoltan
2024-02-23 16:59 ` Philippe Mathieu-Daudé [this message]
2024-02-23 19:19 ` Thomas Huth
2024-02-25 16:57 ` Philippe Mathieu-Daudé
2024-02-25 17:08 ` BALATON Zoltan
2024-02-25 17:19 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e44fde31-ca7f-4b79-87ab-bf94881d1be7@linaro.org \
--to=philmd@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=jsnow@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).