From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyMNt-0008QX-Ij for qemu-devel@nongnu.org; Tue, 20 Mar 2018 14:53:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyMNs-00024k-Mk for qemu-devel@nongnu.org; Tue, 20 Mar 2018 14:53:21 -0400 References: <20180320173632.25480-1-kwolf@redhat.com> <20180320173632.25480-13-kwolf@redhat.com> From: Eric Blake Message-ID: Date: Tue, 20 Mar 2018 13:53:14 -0500 MIME-Version: 1.0 In-Reply-To: <20180320173632.25480-13-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.12 12/12] qemu-iotests: Test vhdx image creation with QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, den@openvz.org, jcody@redhat.com, berrange@redhat.com, qemu-devel@nongnu.org On 03/20/2018 12:36 PM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/213 | 349 +++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/213.out | 121 ++++++++++++++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 471 insertions(+) > create mode 100755 tests/qemu-iotests/213 > create mode 100644 tests/qemu-iotests/213.out > > + > +echo > +echo "=== Invalid sizes ===" > +echo > + > +# TODO Negative image sizes aren't handled correctly, but this is a problem > +# with QAPI's implementation of the 'size' type and affects other commands as > +# well. Once this is fixed, we may want to add a test case here. > + > +# 1. 2^64 - 512 > +# 2. 2^63 = 8 EB (qemu-img enforces image sizes less than this) > +# 3. 2^63 - 512 (generally valid, but with the crypto header the file will > +# exceed 63 bits) Same comments as before on whether this comment is slightly stale after copy-and-paste. > +# 4. 2^46 + 1 (512 bytes more than maximum image size) Does this image format require 512-byte alignment? If so, are you missing a test of unaligned sizes? If not, why not just 1 byte more than the maximum? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org