From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCRu2-0002MK-Ts for qemu-devel@nongnu.org; Wed, 08 Nov 2017 10:04:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCRtz-00051t-PW for qemu-devel@nongnu.org; Wed, 08 Nov 2017 10:04:30 -0500 Received: from mail-wr0-f180.google.com ([209.85.128.180]:56297) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eCRtz-00050z-Jo for qemu-devel@nongnu.org; Wed, 08 Nov 2017 10:04:27 -0500 Received: by mail-wr0-f180.google.com with SMTP id l8so2677218wre.12 for ; Wed, 08 Nov 2017 07:04:27 -0800 (PST) References: <41ed8543e005205118438328c7e162532729d9c7.1510093478.git.jcody@redhat.com> <20171108104737.xtxfex7leabfbqyc@starbug-vm.ie.oracle.com> <20171108145038.7ms6llpt4vjnh33q@starbug-vm.ie.oracle.com> From: Paolo Bonzini Message-ID: Date: Wed, 8 Nov 2017 16:04:21 +0100 MIME-Version: 1.0 In-Reply-To: <20171108145038.7ms6llpt4vjnh33q@starbug-vm.ie.oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3 7/7] block/curl: code cleanup to comply with coding style List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Jeff Cody , qemu-devel@nongnu.org, kwolf@redhat.com, qemu-block@nongnu.org, mitake.hitoshi@lab.ntt.co.jp, rjones@redhat.com, namei.unix@gmail.com On 08/11/2017 15:50, Darren Kenny wrote: >> But, since checkpatch.pl doesn't flag it, and since it is easier to >> remove the leading and trailing /* and */ to enable the debug #defines >> (compared to editing every single line of the comment), I don't see a >> problem with the style chosen here. > > If that is the purpose, maybe an #if 0 is more appropriate or #ifdef > DEBUG, or similar. > > Isn't the purpose of styling to be consistent? As such should we not > be trying to use the multi-line style set out at the top of the file? Yes, and you're very welcome to submit a checkpatch.pl patch that warns about that comment style without * at the beginning of each line. On the other hand, style should not get in the way, and the version that gets least in the way for debug #defines is //. Paolo