From: Richard Henderson <richard.henderson@linaro.org>
To: Helge Deller <deller@gmx.de>, qemu-devel@nongnu.org
Cc: Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH 2/7] hw/hppa: Make number of TLB and BTLB entries configurable
Date: Tue, 1 Sep 2020 14:36:48 -0700 [thread overview]
Message-ID: <e4627473-3272-59e7-a8b6-0f223e69b198@linaro.org> (raw)
In-Reply-To: <20200901183452.24967-3-deller@gmx.de>
On 9/1/20 11:34 AM, Helge Deller wrote:
> diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c
> index 90aeefe2a4..e9d84d0f03 100644
> --- a/hw/hppa/machine.c
> +++ b/hw/hppa/machine.c
> @@ -72,6 +72,14 @@ static FWCfgState *create_fw_cfg(MachineState *ms)
> fw_cfg_add_file(fw_cfg, "/etc/firmware-min-version",
> g_memdup(&val, sizeof(val)), sizeof(val));
>
> + val = cpu_to_le64(HPPA_TLB_ENTRIES);
I guess you don't have a cpu structure here against which you could apply
ARRAY_SIZE?
> /* ??? The number of entries isn't specified by the architecture. */
> + #define HPPA_TLB_ENTRIES 256
> + #define HPPA_BTLB_ENTRIES 0
What's a btlb entry?
The indented defines are weird.
r~
next prev parent reply other threads:[~2020-09-01 21:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 18:34 [PATCH 0/7] hppa power button support, graphics updates and firmware fixes Helge Deller
2020-09-01 18:34 ` [PATCH 1/7] seabios-hppa: Update SeaBIOS to hppa-qemu-5.2-2 tag Helge Deller
2020-09-01 18:34 ` [PATCH 2/7] hw/hppa: Make number of TLB and BTLB entries configurable Helge Deller
2020-09-01 21:36 ` Richard Henderson [this message]
2020-09-02 11:16 ` Helge Deller
2020-09-02 16:52 ` Richard Henderson
2020-09-02 19:36 ` Helge Deller
2020-09-01 18:34 ` [PATCH 3/7] hw/hppa: Store boot device in fw_cfg section Helge Deller
2020-09-01 21:37 ` Richard Henderson
2020-09-01 18:34 ` [PATCH 4/7] hw/hppa: Inform SeaBIOS about fw_cfg port address Helge Deller
2020-09-01 21:39 ` Richard Henderson
2020-09-02 11:24 ` Helge Deller
2020-09-02 16:46 ` Richard Henderson
2020-09-02 19:37 ` Helge Deller
2020-09-01 18:34 ` [PATCH 5/7] hw/hppa: Add power button emulation Helge Deller
2020-09-01 21:42 ` Richard Henderson
2020-09-01 18:34 ` [PATCH 6/7] hw/display/artist: Fix artist screen resolution Helge Deller
2020-09-01 21:49 ` Richard Henderson
2020-09-02 21:48 ` Helge Deller
2020-09-02 22:09 ` Richard Henderson
2020-09-03 6:07 ` Helge Deller
2020-09-03 6:08 ` Helge Deller
2020-09-03 6:09 ` Helge Deller
2020-09-03 15:09 ` Richard Henderson
2020-09-01 18:34 ` [PATCH 7/7] target/hppa: Fix boot with old Linux installation CDs Helge Deller
2020-09-01 19:37 ` [PATCH 0/7] hppa power button support, graphics updates and firmware fixes Philippe Mathieu-Daudé
2020-09-01 19:49 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4627473-3272-59e7-a8b6-0f223e69b198@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).