From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD56EEB64D7 for ; Wed, 28 Jun 2023 06:43:41 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEOtI-0000Ri-4v; Wed, 28 Jun 2023 02:43:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEOtG-0000RM-MF for qemu-devel@nongnu.org; Wed, 28 Jun 2023 02:42:58 -0400 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEOtF-0008Kn-16 for qemu-devel@nongnu.org; Wed, 28 Jun 2023 02:42:58 -0400 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2b69dcf45faso51333061fa.0 for ; Tue, 27 Jun 2023 23:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687934575; x=1690526575; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=M1xAJ0pk+7OhNoSCVNG8ARMKIScywqlsC5HPzuwn/Io=; b=y+Izicx0b6D3Exio7iQVsx2qU0/ydOR0BqLZNHOqUvOAWTfjAp+xyFJ2ZYF7kmjInH at0EIge6wK3AYZLWRlyGAcgEZIi2kZPGfofzb2jgvAw3T79AcgKpaBn/YUpp3U8XgcjE tFXmuKVr9DMpRt2pW7R6JnMhcLiWm4gntVlL/5rsCVdOQ1gdGCO66a8iaxiNJSNPs3Jb 0oV4UY/piNjB2EY+GEDnLcqYxlhL7GhXcyaDRCgQu6Ucw5wihRPPKKxf+zyktjVgqIAf Cd32z/rRwKmPbaeCsPzLI4AfRUQLzE3XTGwwPwkBkASFaV7unYhsMkAFlx6RdsyqAyTi AxcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687934575; x=1690526575; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M1xAJ0pk+7OhNoSCVNG8ARMKIScywqlsC5HPzuwn/Io=; b=f77A1/0thYrjbuOqv6mSUMoq0SKi6E/dR+8meyGFG7HB+A3IQbO4QID9u5cNKJy4Ly yXG11wlHEbjKtRGTtJ13fMThxtfBFVPAHge6YBeI4tb6DUVlwZfoC9ETU4qEVuJuekhj imptebsWbv+m8HjUWDyQgbqnoqp99hnTe//vTkn19yLrrrarCQUSdxr8ImXsYH+WWh6s 8iGfU0YodZZkqSGhFVsch+/GrPWDfKIl1itk93ZxMBgPqCNN9/MBqQMEYpGJWMHT+UZn CKYpd7vmXUvi2LA9z8yr31sSgvy1cW799bId7cTsAkuMJ1wAKynKn9InpFBAXVmTpmd+ DLrA== X-Gm-Message-State: AC+VfDzMXhwIbcbscJ3dlERtOx/hLaFF6yiZSbo0GLJ6aTaxa6fYi0aW wJl84hDosRWNTDxiWnhwJgIASzq9HnrBN+4S2bQ= X-Google-Smtp-Source: ACHHUZ790nxaJWDjBmbx94ZDumUJNvx3IQLEXw1wavHvNTC7W6Tv3cegdZOmUNRKojb+3Plsj6XrKw== X-Received: by 2002:a2e:7306:0:b0:2b6:9930:871 with SMTP id o6-20020a2e7306000000b002b699300871mr6179927ljc.13.1687934575116; Tue, 27 Jun 2023 23:42:55 -0700 (PDT) Received: from [192.168.69.115] ([176.187.207.229]) by smtp.gmail.com with ESMTPSA id c1-20020a056000104100b0031402a910edsm3108466wrx.86.2023.06.27.23.42.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jun 2023 23:42:54 -0700 (PDT) Message-ID: Date: Wed, 28 Jun 2023 08:42:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v6 2/3] hw/riscv: sifive_e: Support the watchdog timer of HiFive 1 rev b. Content-Language: en-US To: Tommy Wu , qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: alistair.francis@wdc.com, palmer@dabbelt.com, bin.meng@windriver.com, jim.shu@sifive.com, frank.chang@sifive.com, liweiwei@iscas.ac.cn References: <20230627141216.3962299-1-tommy.wu@sifive.com> <20230627141216.3962299-3-tommy.wu@sifive.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230627141216.3962299-3-tommy.wu@sifive.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::235; envelope-from=philmd@linaro.org; helo=mail-lj1-x235.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.103, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 27/6/23 16:12, Tommy Wu wrote: > Create the AON device when we realize the sifive_e machine. > This patch only implemented the functionality of the watchdog timer, > not all the functionality of the AON device. > > Signed-off-by: Tommy Wu > Reviewed-by: Frank Chang > Reviewed-by: Alistair Francis > --- > hw/riscv/Kconfig | 1 + > hw/riscv/sifive_e.c | 17 +++++++++++++++-- > include/hw/riscv/sifive_e.h | 9 ++++++--- > 3 files changed, 22 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé