From: Richard Henderson <richard.henderson@linaro.org>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 4/8] target/tricore: Indirect jump insns use tcg_gen_lookup_and_goto_ptr()
Date: Sun, 18 Jun 2023 19:34:10 +0200 [thread overview]
Message-ID: <e4673a26-f943-88ee-6cbb-88ff78a1749a@linaro.org> (raw)
In-Reply-To: <20230616152808.1499082-5-kbastian@mail.uni-paderborn.de>
On 6/16/23 17:28, Bastian Koppelmann wrote:
> @@ -6075,7 +6076,7 @@ static void decode_rr_idirect(DisasContext *ctx)
> default:
> generate_trap(ctx, TRAPC_INSN_ERR, TIN2_IOPC);
> }
> - ctx->base.is_jmp = DISAS_EXIT;
> + ctx->base.is_jmp = DISAS_JUMP;
> }
Not quite correct, as generate_trap is NORETURN.
Return early from the function there?
r~
next prev parent reply other threads:[~2023-06-18 17:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 15:28 [PATCH v2 0/8] TriCore Privilege Levels Bastian Koppelmann
2023-06-16 15:28 ` [PATCH v2 1/8] target/tricore: Fix RR_JLI clobbering reg A[11] Bastian Koppelmann
2023-06-18 17:30 ` Richard Henderson
2023-06-16 15:28 ` [PATCH v2 2/8] target/tricore: Introduce DISAS_TARGET_EXIT Bastian Koppelmann
2023-06-18 17:31 ` Richard Henderson
2023-06-16 15:28 ` [PATCH v2 3/8] target/tricore: ENABLE/DISABLE exit to main-loop Bastian Koppelmann
2023-06-18 17:32 ` Richard Henderson
2023-06-16 15:28 ` [PATCH v2 4/8] target/tricore: Indirect jump insns use tcg_gen_lookup_and_goto_ptr() Bastian Koppelmann
2023-06-18 17:34 ` Richard Henderson [this message]
2023-06-16 15:28 ` [PATCH v2 5/8] target/tricore: Introduce priv tb flag Bastian Koppelmann
2023-06-16 15:28 ` [PATCH v2 6/8] target/tricore: Implement privilege level for all insns Bastian Koppelmann
2023-06-16 15:28 ` [PATCH v2 7/8] target/tricore: Honour privilege changes on PSW write Bastian Koppelmann
2023-06-18 17:34 ` Richard Henderson
2023-06-16 15:28 ` [PATCH v2 8/8] target/tricore: Fix ICR.IE offset in RESTORE insn Bastian Koppelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4673a26-f943-88ee-6cbb-88ff78a1749a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=kbastian@mail.uni-paderborn.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).