From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F3ECC32753 for ; Wed, 14 Aug 2019 15:14:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44C0E2083B for ; Wed, 14 Aug 2019 15:14:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44C0E2083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxuz8-0001lp-Dg for qemu-devel@archiver.kernel.org; Wed, 14 Aug 2019 11:14:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38669) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxuyT-0001IK-Mk for qemu-devel@nongnu.org; Wed, 14 Aug 2019 11:14:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxuyS-00048e-Fm for qemu-devel@nongnu.org; Wed, 14 Aug 2019 11:14:05 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:33445) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hxuyS-00047K-AT for qemu-devel@nongnu.org; Wed, 14 Aug 2019 11:14:04 -0400 Received: by mail-wr1-f65.google.com with SMTP id u16so422742wrr.0 for ; Wed, 14 Aug 2019 08:14:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UHz+PG4PV6GATCmJjgUGyzHjmY/8iRvRgRrwmG8dGbQ=; b=BW72Gps5vbg8iVB9cuCbjCSk7DKh7nLS1O9L6uH9VW2q5VP95z2S6qL0F4/G36nTv/ DEUZR04eryeZyp25D4AT50zfVjODnAyLqoW6b/CW0Pg9H19+017bvMxpg0oDzi3+Byqo F0qPpY31JT0FDONI0EdEtMCVUMKfTtIJ9qcoKfNIdiYEdjekMkifDNFDuP71GHh1Pyaf B1Yd32+Mkw0zBgiuYGJWq9k4Kt2aWkSHHakRGUwvOdZVmFi9x4hc5oGIuTemGIHtJ/83 h2ustGyAZyGp93A4NvhG8BwgnPZ4snhFE1goIVz/ii3IIgnpRp4/miLkPr2ZkiTAzn7s EOhA== X-Gm-Message-State: APjAAAWu8tnj659HbEhKRlIfRUdhrloV8Lsg04iqe0Fb7XpFZYHkTQR4 e2sN3c0lY1JsrSanQge8sK5kSA== X-Google-Smtp-Source: APXvYqxXKmGXPvAV7nZn03JIj+cyYhyxj5juqW4B/zkt+YwAV/nMi+QKJe2xm84d+FatQACO5o+4Pg== X-Received: by 2002:a5d:5183:: with SMTP id k3mr216712wrv.270.1565795643271; Wed, 14 Aug 2019 08:14:03 -0700 (PDT) Received: from [192.168.1.39] (251.red-88-10-102.dynamicip.rima-tde.net. [88.10.102.251]) by smtp.gmail.com with ESMTPSA id w7sm120723wrn.11.2019.08.14.08.14.02 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 14 Aug 2019 08:14:02 -0700 (PDT) To: Andrea Bolognani , "Richard W . M . Jones" , qemu-devel@nongnu.org, Pino Toscano References: <20190814121527.17876-1-philmd@redhat.com> <20190814121527.17876-3-philmd@redhat.com> <4876e26ccda980f45e0ad1492097a66b07fe65de.camel@redhat.com> <9becb1b8d13703740411ae0e1e6e0580fe6a1bc7.camel@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Wed, 14 Aug 2019 17:14:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <9becb1b8d13703740411ae0e1e6e0580fe6a1bc7.camel@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.65 Subject: Re: [Qemu-devel] [PATCH 2/4] configure: Avoid using libssh deprecated API X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , =?UTF-8?B?5ZGo5paH6Z2S?= <1151451036@qq.com>, =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/14/19 4:51 PM, Andrea Bolognani wrote: > On Wed, 2019-08-14 at 16:15 +0200, Philippe Mathieu-Daudé wrote: >> On 8/14/19 3:27 PM, Andrea Bolognani wrote: >>> On Wed, 2019-08-14 at 14:15 +0200, Philippe Mathieu-Daudé wrote: >>>> The libssh packaged by a distribution can predate version 0.8, >>>> but still provides the newer API introduced after version 0.7. >>>> >>>> Using the deprecated API leads to build failure, as on Ubuntu 18.04: >>>> >>>> CC block/ssh.o >>>> block/ssh.c: In function 'check_host_key_hash': >>>> block/ssh.c:444:5: error: 'ssh_get_publickey' is deprecated [-Werror=deprecated-declarations] >>>> r = ssh_get_publickey(s->session, &pubkey); >>>> ^ >>>> In file included from block/ssh.c:27:0: >>>> /usr/include/libssh/libssh.h:489:31: note: declared here >>>> SSH_DEPRECATED LIBSSH_API int ssh_get_publickey(ssh_session session, ssh_key *key); >>>> ^~~~~~~~~~~~~~~~~ >>>> rules.mak:69: recipe for target 'block/ssh.o' failed >>>> make: *** [block/ssh.o] Error 1 >>>> >>>> Fix by using the newer API if available. >>>> >>>> Suggested-by: Andrea Bolognani >>>> Signed-off-by: Philippe Mathieu-Daudé >>>> --- >>>> block/ssh.c | 2 +- >>>> configure | 7 +++++++ >>>> 2 files changed, 8 insertions(+), 1 deletion(-) >>> >>> Did I really suggest this? I have no recollection of doing so, or >>> even getting involved with libssh support in QEMU at all for that >>> matter. >> >> I took this suggestion from >> https://www.redhat.com/archives/libvir-list/2018-May/msg00597.html > > I see :) > > I feel like adding a Suggested-by because of something that was > posted on an unrelated project's mailing list is stretching the > definition of the tag a bit, so if you end up having to respin I > think it would be reasonable to drop it, but honestly it's not a > big deal either way: I was just curious. Understood, sorry.