qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: "Willian Rampazzo" <willianr@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: Re: [RFC PATCH] gitlab: default to not building the documentation
Date: Mon, 22 Mar 2021 17:06:45 +0100	[thread overview]
Message-ID: <e4946ac6-8580-c8fc-ae1b-f1907f00bdce@redhat.com> (raw)
In-Reply-To: <20210322144140.13505-1-alex.bennee@linaro.org>

On 22/03/2021 15.41, Alex Bennée wrote:
> In d0f26e68a0 ("gitlab: force enable docs build in Fedora, Ubuntu,
> Debian") we made sure we can build the documents on more than one
> system. However we don't want to build documents all the time as it's
> a waste of cycles (and energy). So lets reduce the total amount of
> documentation we build while still keeping some coverage.
> 
> Fixes: a8a3abe0b3 ("gitlab: move docs and tools build across from Travis")
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   .gitlab-ci.yml | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 9ffbaa7ffb..7714c7cac8 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -23,9 +23,9 @@ include:
>       - cd build
>       - if test -n "$TARGETS";
>         then
> -        ../configure --enable-werror $CONFIGURE_ARGS --target-list="$TARGETS" ;
> +        ../configure --enable-werror --disable-docs $CONFIGURE_ARGS --target-list="$TARGETS" ;
>         else
> -        ../configure --enable-werror $CONFIGURE_ARGS ;
> +        ../configure --enable-werror --disable-docs $CONFIGURE_ARGS ;
>         fi || { cat config.log meson-logs/meson-log.txt && exit 1; }
>       - if test -n "$LD_JOBS";
>         then
> @@ -119,7 +119,7 @@ build-system-ubuntu:
>       job: amd64-ubuntu2004-container
>     variables:
>       IMAGE: ubuntu2004
> -    CONFIGURE_ARGS: --enable-fdt=system --enable-slirp=system
> +    CONFIGURE_ARGS: --enable-docs --enable-fdt=system --enable-slirp=system

I think it might be better to add it to the Fedora job - it will likely have 
a newer version of Sphinx and gets updated more often.

  Thomas



  reply	other threads:[~2021-03-22 16:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22 14:41 [RFC PATCH] gitlab: default to not building the documentation Alex Bennée
2021-03-22 16:06 ` Thomas Huth [this message]
2021-03-22 16:24   ` Alex Bennée
2021-03-22 16:31     ` Thomas Huth
2021-03-22 16:42 ` Peter Maydell
2021-03-22 17:20   ` Alex Bennée
2021-03-22 16:59 ` Willian Rampazzo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4946ac6-8580-c8fc-ae1b-f1907f00bdce@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    --cc=willianr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).