Re: [Qemu-devel] [PATCH v3 15/16] block/mirror: Add copy mode QAPI interface

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]

On 2018-03-20 18:35, Eric Blake wrote:
> On 02/28/2018 12:05 PM, Max Reitz wrote:
>> This patch allows the user to specify whether to use active or only
>> background mode for mirror block jobs.  Currently, this setting will
>> remain constant for the duration of the entire block job.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   qapi/block-core.json      | 11 +++++++++--
>>   include/block/block_int.h |  4 +++-
>>   block/mirror.c            | 12 +++++++-----
>>   blockdev.c                |  9 ++++++++-
>>   4 files changed, 27 insertions(+), 9 deletions(-)
>>
>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>> index c73b769c27..1186c007ae 100644
>> --- a/qapi/block-core.json
>> +++ b/qapi/block-core.json
>> @@ -1573,6 +1573,9 @@
>>   #         written. Both will result in identical contents.
>>   #         Default is true. (Since 2.4)
>>   #
>> +# @copy-mode: when to copy data to the destination; defaults to
>> 'background'
>> +#             (Since: 2.12)
>> +#
> 
> Are we still aiming for 2.12, or is this a feature which missed
> softfreeze and should therefore be 2.13?

The latter, I'll change it in v4.

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]