From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH v4 1/7] target/arm: Improve masking of HCR RES0 bits
Date: Fri, 28 Feb 2020 08:57:33 -0800 [thread overview]
Message-ID: <e4a70637-f4b7-eaa7-237a-57053c5a63cc@linaro.org> (raw)
In-Reply-To: <CAFEAcA8ipK0nZioEgbNq5B1L-tqA+rzn-C2yyfet4_4yNVnYqA@mail.gmail.com>
On 2/28/20 8:22 AM, Peter Maydell wrote:
>> + if (ri->state == ARM_CP_STATE_AA32) {
>> + /*
>> + * Writes from aarch32 mode have more RES0 bits.
>> + * This includes TDZ, RW, E2H, and more.
>> + */
>> + valid_mask &= ~0xff80ff8c90000000ull;
>> + }
>
> Isn't bit HCR2 bit 16 (aka bit 32+16==48 here) also RES0 from AArch32 ?
Yes, and it's set in the above.
> I'm not really a fan of the hex-number here either, given we
> have HCR_* constants.
While plenty of those bits have names, many don't. Shall I simply name all of
the ones that have names, and that differ from the aa64 masking?
r~
next prev parent reply other threads:[~2020-02-28 17:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 18:08 [PATCH v4 0/7] target/arm: Honor more HCR_EL2 traps Richard Henderson
2020-02-25 18:08 ` [PATCH v4 1/7] target/arm: Improve masking of HCR RES0 bits Richard Henderson
2020-02-28 16:22 ` Peter Maydell
2020-02-28 16:57 ` Richard Henderson [this message]
2020-02-28 17:34 ` Peter Maydell
2020-02-28 18:55 ` Richard Henderson
2020-02-28 19:03 ` Peter Maydell
2020-02-28 22:24 ` Richard Henderson
2020-02-25 18:08 ` [PATCH v4 2/7] target/arm: Honor the HCR_EL2.{TVM,TRVM} bits Richard Henderson
2020-02-28 16:24 ` Peter Maydell
2020-02-25 18:08 ` [PATCH v4 3/7] target/arm: Honor the HCR_EL2.TSW bit Richard Henderson
2020-02-25 18:08 ` [PATCH v4 4/7] target/arm: Honor the HCR_EL2.TACR bit Richard Henderson
2020-02-25 18:08 ` [PATCH v4 5/7] target/arm: Honor the HCR_EL2.TPCP bit Richard Henderson
2020-02-28 16:25 ` Peter Maydell
2020-02-25 18:08 ` [PATCH v4 6/7] target/arm: Honor the HCR_EL2.TPU bit Richard Henderson
2020-02-28 16:25 ` Peter Maydell
2020-02-25 18:08 ` [PATCH v4 7/7] target/arm: Honor the HCR_EL2.TTLB bit Richard Henderson
2020-02-28 16:28 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4a70637-f4b7-eaa7-237a-57053c5a63cc@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).