From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E8E9C433B4 for ; Mon, 19 Apr 2021 13:46:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A91860FEF for ; Mon, 19 Apr 2021 13:46:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A91860FEF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYUEn-00023R-7Z for qemu-devel@archiver.kernel.org; Mon, 19 Apr 2021 09:46:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53194) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYUCn-0000ev-T2 for qemu-devel@nongnu.org; Mon, 19 Apr 2021 09:44:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:31429) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYUCl-0005uN-I4 for qemu-devel@nongnu.org; Mon, 19 Apr 2021 09:44:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618839886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+L98JWf2yYITM83OFeNoKPCMjtNa4W3fEJlI6stbA4M=; b=IpgviaYqw5CMqPAdJFhFkutNgRef/lC4kZiqQcX8qzCI6HUeLW/+fmAWH0nmvaAedQ/kYm VY57zwGrFX1IP7+nGpXgs6Vj3am6/zf3alFV4bYE7/n1bO7q33q+MRNudWB2PrIKNrGx8V dISmwlKrkHj/dvRQe9dkXsKMoW39Y5o= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-434-b4dUOzRUN320_neeAeEDsg-1; Mon, 19 Apr 2021 09:44:45 -0400 X-MC-Unique: b4dUOzRUN320_neeAeEDsg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3A9BA195D561; Mon, 19 Apr 2021 13:44:44 +0000 (UTC) Received: from wainer-laptop.localdomain (ovpn-116-102.gru2.redhat.com [10.97.116.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id 30C19F6D7; Mon, 19 Apr 2021 13:44:34 +0000 (UTC) Subject: Re: [PATCH 08/15] gitlab-ci: Extract DCO/style check jobs to checks.yml To: Thomas Huth , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210418233448.1267991-1-f4bug@amsat.org> <20210418233448.1267991-9-f4bug@amsat.org> <61a57a93-2bd6-bd1c-1826-de9c679a0f87@redhat.com> From: Wainer dos Santos Moschetta Message-ID: Date: Mon, 19 Apr 2021 10:44:31 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <61a57a93-2bd6-bd1c-1826-de9c679a0f87@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wainersm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=170.10.133.124; envelope-from=wainersm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Daniel_P_=2e_Berrang=c3=a9?= , Erik Skultety , Willian Rampazzo , Cleber Rosa , Miroslav Rezanina , =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/19/21 2:26 AM, Thomas Huth wrote: > On 19/04/2021 01.34, Philippe Mathieu-Daudé wrote: >> Extract the DCO / checkpatch jobs to a new file (checks.yml) >> to be able to run them without having to run all the jobs >> included in the default .gitlab-ci.yml, which are mainly useful >> for mainstream CI. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>   .gitlab-ci.d/checks.yml | 24 ++++++++++++++++++++++++ >>   .gitlab-ci.yml          |  1 + >>   2 files changed, 25 insertions(+) >>   create mode 100644 .gitlab-ci.d/checks.yml >> >> diff --git a/.gitlab-ci.d/checks.yml b/.gitlab-ci.d/checks.yml >> new file mode 100644 >> index 00000000000..f695627b7cd >> --- /dev/null >> +++ b/.gitlab-ci.d/checks.yml >> @@ -0,0 +1,24 @@ >> +check-patch: >> +  stage: build >> +  image: $CI_REGISTRY_IMAGE/qemu/centos8:latest >> +  needs: >> +    job: amd64-centos8-container >> +  script: .gitlab-ci.d/check-patch.py >> +  except: >> +    variables: >> +      - $CI_PROJECT_NAMESPACE == 'qemu-project' && $CI_COMMIT_BRANCH >> == 'master' >> +  variables: >> +    GIT_DEPTH: 1000 >> +  allow_failure: true >> + >> +check-dco: >> +  stage: build >> +  image: $CI_REGISTRY_IMAGE/qemu/centos8:latest >> +  needs: >> +    job: amd64-centos8-container >> +  script: .gitlab-ci.d/check-dco.py >> +  except: >> +    variables: >> +      - $CI_PROJECT_NAMESPACE == 'qemu-project' && $CI_COMMIT_BRANCH >> == 'master' >> +  variables: >> +    GIT_DEPTH: 1000 >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml >> index bf4862a78de..ba35b3917e7 100644 >> --- a/.gitlab-ci.yml >> +++ b/.gitlab-ci.yml >> @@ -12,6 +12,7 @@ include: >>     - local: '/.gitlab-ci.d/opensbi.yml' >>     - local: '/.gitlab-ci.d/containers.yml' >>     - local: '/.gitlab-ci.d/crossbuilds.yml' >> +  - local: '/.gitlab-ci.d/checks.yml' >>     .native_build_job_template: >>     stage: build >> > > You added the new file, but it looks like you did not remove the jobs > from the main .gitlab-ci.yml file ? ... that looks like a mistake? > > Also, "checks.yml" sounds a little bit too generic. Maybe rather name > it "style-check.yml" or something similar? Maybe "static_checks.yml". - Wainer > > >  Thomas