From: Paolo Bonzini <pbonzini@redhat.com>
To: Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>
Cc: borntraeger@de.ibm.com, qemu-devel@nongnu.org, palves@redhat.com,
alex.bennee@linaro.org
Subject: Re: [Qemu-devel] [PATCH v7 2/2] gdbstub: Fix vCont behaviour
Date: Tue, 7 Feb 2017 16:10:13 +0100 [thread overview]
Message-ID: <e4d4404a-5966-3ed7-1c51-8ed45d626190@redhat.com> (raw)
In-Reply-To: <db1dcc0a-61fe-652b-b994-12fb3dc10780@linux.vnet.ibm.com>
On 07/02/2017 10:59, Claudio Imbrenda wrote:
> static inline int cpu_index(CPUState *cpu)
> {
> #if defined(CONFIG_USER_ONLY)
> return cpu->host_tid;
> #else
> return cpu->cpu_index + 1;
> #endif
> }
>
>
> maybe that can just become newstates[cpu->cpu_index] = 1 ?
> (since we're not in CONFIG_USER_ONLY anyway)
Yes, I think it should be like that, especially if in the future we want
to support CONFIG_USER_ONLY it makes no sense to use host PIDs.
Paolo
prev parent reply other threads:[~2017-02-07 15:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 18:11 [Qemu-devel] [PATCH v7 0/2] Qemu: gdbstub: fix vCont Claudio Imbrenda
2017-01-27 18:11 ` [Qemu-devel] [PATCH v7 1/2] move vm_start to cpus.c Claudio Imbrenda
2017-02-06 9:53 ` Paolo Bonzini
2017-01-27 18:11 ` [Qemu-devel] [PATCH v7 2/2] gdbstub: Fix vCont behaviour Claudio Imbrenda
2017-02-06 10:00 ` Paolo Bonzini
2017-02-07 9:59 ` Claudio Imbrenda
2017-02-07 15:10 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4d4404a-5966-3ed7-1c51-8ed45d626190@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=borntraeger@de.ibm.com \
--cc=imbrenda@linux.vnet.ibm.com \
--cc=palves@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).