From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] hw/audio/gus: Use AUDIO_HOST_ENDIANNESS definition from 'audio/audio.h'
Date: Tue, 5 May 2020 12:49:41 +0200 [thread overview]
Message-ID: <e4de9abb-114b-239e-ec33-ef1f4a5a7f85@redhat.com> (raw)
In-Reply-To: <79194c5a-ea10-3921-aeb4-1e0432b38c3d@amsat.org>
On 05/05/20 12:45, Philippe Mathieu-Daudé wrote:
> On 5/5/20 12:10 PM, Paolo Bonzini wrote:
>> On 05/05/20 12:07, Philippe Mathieu-Daudé wrote:
>>> Use the generic AUDIO_HOST_ENDIANNESS definition instead
>>> of a custom one.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> Who/what machine is using this device anyway?
>>
>> PC, like all old ISA audio cards.
>
> I imagined, but any particular project in mind? I'm wondering if we
> should add a test for it, and what kind of testing.
Old games and demos use it. Most demos don't work that well on QEMU though.
Paolo
next prev parent reply other threads:[~2020-05-05 10:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 10:07 [PATCH] hw/audio/gus: Use AUDIO_HOST_ENDIANNESS definition from 'audio/audio.h' Philippe Mathieu-Daudé
2020-05-05 10:10 ` Paolo Bonzini
2020-05-05 10:45 ` Philippe Mathieu-Daudé
2020-05-05 10:49 ` Paolo Bonzini [this message]
2020-05-05 10:55 ` Philippe Mathieu-Daudé
2020-05-05 11:09 ` Max Reitz
2020-05-26 6:05 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4de9abb-114b-239e-ec33-ef1f4a5a7f85@redhat.com \
--to=pbonzini@redhat.com \
--cc=f4bug@amsat.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).