From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2CA1C433F5 for ; Tue, 23 Nov 2021 13:51:01 +0000 (UTC) Received: from localhost ([::1]:38686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpWCK-0000dY-Fh for qemu-devel@archiver.kernel.org; Tue, 23 Nov 2021 08:51:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpWAk-0007Dh-EG for qemu-devel@nongnu.org; Tue, 23 Nov 2021 08:49:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:54871) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpWAg-0004f6-BU for qemu-devel@nongnu.org; Tue, 23 Nov 2021 08:49:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637675357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dYakA3F55O53MQ7zpkVm5nmYNpmaTH3xLMEhkjQMThs=; b=Np82Kok+RSTitxznGpSEzRPZ+Ih8pexsdHqasXA8lc3aUZqePJshEu50z9KRQzqwuCvAmt fv0YE4l/wdtuYo+LruBij2Sd0c7j91IffI0idSDBGoZ4nloxSsIpVj5OMaIyQmmXjKG9Gc njECcKx8SPKMgIr4diw13VWddmdMqac= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-373-rs-NgkSyOqS5w0J9h_u7Qg-1; Tue, 23 Nov 2021 08:49:15 -0500 X-MC-Unique: rs-NgkSyOqS5w0J9h_u7Qg-1 Received: by mail-wm1-f69.google.com with SMTP id k25-20020a05600c1c9900b00332f798ba1dso1257241wms.4 for ; Tue, 23 Nov 2021 05:49:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=dYakA3F55O53MQ7zpkVm5nmYNpmaTH3xLMEhkjQMThs=; b=HBBnX9uqPmxw8Zwrt7OA/aUWJqJYZUtOVMnnpBXvCPCTh5tI5Yfz+keYvkFQVuBBNq orItHaPxIAbYGA9EwGNrCw6re4uLcZsQB7dIPUYB8a9e1qpaE9Dom2nItKKilZ4xfJfK L7FNxoconqlkau+g5goEl/RgjKOw+DjtdYIs/yx6Coc5p/6OS6Nvdi3KD03u1/31SQCH 3Q5uiIhlrI/sg0BiddAFZCRuuT2HpCc8eRmfIGLgJskN5fC8jCJnJFt3TN1kZLYOvlSn +D3VIVB1Rd5RZ40b8CTTFSrOmYmZIQ0sAn95DN6SAcIBqSRuDSkTwvLdrFVcx5+BWOC/ OzSg== X-Gm-Message-State: AOAM5324IvWxw346lntzpbAEyRnPkTgOSsnOB1K+nNIr6MkUx3xchYaB TARmUuXCQtR/BTjBLZXqcYzJ3WoXF1dfDAYvJjFuf03ivQcYoGMCmDkNM9enEdaaAVajleXjmpZ ublLAGG4N7qO6XzU= X-Received: by 2002:a05:6000:2c7:: with SMTP id o7mr7600923wry.62.1637675354640; Tue, 23 Nov 2021 05:49:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJysrkX9h+Ky0F5WLDORzHisAuxyyYI6iEYQ4rTFiZ3Zo+xKIXTc+4W2816+6Hmb4ZWjIEErVQ== X-Received: by 2002:a05:6000:2c7:: with SMTP id o7mr7600871wry.62.1637675354339; Tue, 23 Nov 2021 05:49:14 -0800 (PST) Received: from [192.168.1.36] (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id h27sm1467517wmc.43.2021.11.23.05.49.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Nov 2021 05:49:13 -0800 (PST) Message-ID: Date: Tue, 23 Nov 2021 14:49:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH-for-6.2 v3 2/2] tests/qtest/fdc-test: Add a regression test for CVE-2021-20196 To: Hanna Reitz , qemu-devel@nongnu.org References: <20211118120635.4043197-1-philmd@redhat.com> <20211118120635.4043197-3-philmd@redhat.com> <1cca5391-18e9-8e29-9c8b-0d44010cdecd@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <1cca5391-18e9-8e29-9c8b-0d44010cdecd@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -69 X-Spam_score: -7.0 X-Spam_bar: ------- X-Spam_report: (-7.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.515, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Kevin Wolf , Thomas Huth , Prasad J Pandit , qemu-block@nongnu.org, Darren Kenny , Markus Armbruster , Alexander Bulekov , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Paolo Bonzini , Gaoning Pan , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/23/21 14:42, Hanna Reitz wrote: > On 18.11.21 13:06, Philippe Mathieu-Daudé wrote: >> From: Alexander Bulekov >> >> Without the previous commit, when running 'make check-qtest-i386' >> with QEMU configured with '--enable-sanitizers' we get: >> >>    AddressSanitizer:DEADLYSIGNAL >>    ================================================================= >>    ==287878==ERROR: AddressSanitizer: SEGV on unknown address >> 0x000000000344 >>    ==287878==The signal is caused by a WRITE memory access. >>    ==287878==Hint: address points to the zero page. >>        #0 0x564b2e5bac27 in blk_inc_in_flight >> block/block-backend.c:1346:5 >>        #1 0x564b2e5bb228 in blk_pwritev_part block/block-backend.c:1317:5 >>        #2 0x564b2e5bcd57 in blk_pwrite block/block-backend.c:1498:11 >>        #3 0x564b2ca1cdd3 in fdctrl_write_data hw/block/fdc.c:2221:17 >>        #4 0x564b2ca1b2f7 in fdctrl_write hw/block/fdc.c:829:9 >>        #5 0x564b2dc49503 in portio_write softmmu/ioport.c:201:9 >> >> Add the reproducer for CVE-2021-20196. >> >> Signed-off-by: Alexander Bulekov >> Message-Id: <20210319050906.14875-2-alxndr@bu.edu> >> [PMD: Rebased, use global test_image] >> Reviewed-by: Darren Kenny >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>   tests/qtest/fdc-test.c | 21 +++++++++++++++++++++ >>   1 file changed, 21 insertions(+) > > Not sure if I’m doing something wrong, but: > > Using the global test_image brings a problem, namely that this test > fails unconditionally (for me at least...?), with the reason being that > the global QEMU instance (launched by qtest_start(), quit by > qtest_end()) still has that image open, so by launching a second > instance concurrently, I get this: > > qemu-system-x86_64: Failed to get "write" lock > Is another process using the image [/tmp/qtest.xV4IxX]? Hmm I had too many odd problems running qtests in parallel so I switched to 'make check-qtest -j1' more than 1 year ago, which is probably why I haven't noticed that issue. Using another 'test_image' seems against code reuse principle, but at this point in release, duplicating it is simpler. Someone will clean that later =) > So either we need to use a different image file, or we need to quit the > global instance before using it (e.g. putting a qtest_end() at the > beginning of test_cve_*()), although the latter just seems wrong. > > Second, I can’t make this test fail.  When I apply this patch first (to > master) and run it, I don’t get a SIGSEGV. Is your QEMU built with --enable-sanitizers ?