Re: [Qemu-devel] [PATCH 1/2] tests/stubs: Add a dummy, silent monitor

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]

On 10/20/2016 05:36 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> We need an easy way to silence error_report's that come
> up in meant-to-fail test cases.  The easiest way to do
> that is to create a monitor instance, and since our stubbed
> monitor_printf's are slent this causes the errors to disappear.

s/slent/silent/

> 
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
>  stubs/mon-is-qmp.c | 9 +++++++++
>  tests/libqtest.h   | 1 +
>  2 files changed, 10 insertions(+)
> 
> diff --git a/stubs/mon-is-qmp.c b/stubs/mon-is-qmp.c
> index a8344ce..012eb28 100644
> --- a/stubs/mon-is-qmp.c
> +++ b/stubs/mon-is-qmp.c
> @@ -2,7 +2,16 @@
>  #include "qemu-common.h"
>  #include "monitor/monitor.h"
>  
> +/* Monitor is defined internally to the real monitor.c, so

s/so/but/

> + * it's real contents are never accessed when stubs are in use;

s/it's/its/  ("it's" is only appropriate if "it is" also works)


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]