From: Laurent Vivier <lvivier@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] trace-events,pci: unify trace events format
Date: Wed, 15 Dec 2021 11:57:58 +0100 [thread overview]
Message-ID: <e5011077-3285-cb70-9948-27f84b407dba@redhat.com> (raw)
In-Reply-To: <20211107033751-mutt-send-email-mst@kernel.org>
On 07/11/2021 09:38, Michael S. Tsirkin wrote:
> On Fri, Nov 05, 2021 at 08:25:41PM +0100, Laurent Vivier wrote:
>> Unify format used by trace_pci_update_mappings_del(),
>> trace_pci_update_mappings_add(), trace_pci_cfg_write() and
>> trace_pci_cfg_read() to print the device name and bus number,
>> slot number and function number.
>>
>> For instance:
>>
>> pci_cfg_read virtio-net-pci 00:0 @0x20 -> 0xffffc00c
>> pci_cfg_write virtio-net-pci 00:0 @0x20 <- 0xfea0000c
>> pci_update_mappings_del d=0x555810b92330 01:00.0 4,0xffffc000+0x4000
>> pci_update_mappings_add d=0x555810b92330 01:00.0 4,0xfea00000+0x4000
>>
>> becomes
>>
>> pci_cfg_read virtio-net-pci 01:00.0 @0x20 -> 0xffffc00c
>> pci_cfg_write virtio-net-pci 01:00.0 @0x20 <- 0xfea0000c
>> pci_update_mappings_del virtio-net-pci 01:00.0 4,0xffffc000+0x4000
>> pci_update_mappings_add virtio-net-pci 01:00.0 4,0xfea00000+0x4000
>>
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>
> Looks good to me. We are in freeze, will queue. Pls ping after
> the release to make sure it's not lost.
Ping ?
Thanks,
Laurent
next prev parent reply other threads:[~2021-12-15 11:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 19:25 [PATCH] trace-events,pci: unify trace events format Laurent Vivier
2021-11-05 19:28 ` Philippe Mathieu-Daudé
2021-11-06 2:39 ` wangyanan (Y)
2021-11-07 8:38 ` Michael S. Tsirkin
2021-12-15 10:57 ` Laurent Vivier [this message]
2022-01-05 14:56 ` Laurent Vivier
2022-01-05 15:17 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5011077-3285-cb70-9948-27f84b407dba@redhat.com \
--to=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).