From: Paolo Bonzini <pbonzini@redhat.com>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Xu <peterx@redhat.com>, Leonardo Bras <leobras@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH v5 2/2] migration: Make dirty_bytes_last_sync atomic
Date: Thu, 27 Apr 2023 10:19:28 +0200 [thread overview]
Message-ID: <e50334ea-9ae6-13d1-ac41-035f07ce7980@redhat.com> (raw)
In-Reply-To: <20230426201002.15414-3-quintela@redhat.com>
On 4/26/23 22:10, Juan Quintela wrote:
> Don't use __nocheck() functions.
Doesn't this break on 32-bit platforms?
#if defined(__x86_64__) || defined(__sparc__) || defined(__mips64)
# define ATOMIC_REG_SIZE 8
#else
# define ATOMIC_REG_SIZE sizeof(void *)
#endif
#define qatomic_set(ptr, i) do { \
qemu_build_assert(sizeof(*ptr) <= ATOMIC_REG_SIZE); \
qatomic_set__nocheck(ptr, i); \
} while(0)
So if sizeof(void*) == 4 it would trigger a compile-time assertion.
Paolo
next prev parent reply other threads:[~2023-04-27 8:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 20:10 [PATCH v5 0/2] Migration: Make more ram_counters atomic Juan Quintela
2023-04-26 20:10 ` [PATCH v5 1/2] migration: Make dirty_pages_rate atomic Juan Quintela
2023-04-27 8:17 ` Paolo Bonzini
2023-04-26 20:10 ` [PATCH v5 2/2] migration: Make dirty_bytes_last_sync atomic Juan Quintela
2023-04-27 8:19 ` Paolo Bonzini [this message]
2023-04-27 8:40 ` Juan Quintela
2023-04-27 8:41 ` [PATCH v5 0/2] Migration: Make more ram_counters atomic Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e50334ea-9ae6-13d1-ac41-035f07ce7980@redhat.com \
--to=pbonzini@redhat.com \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).