From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmngx-0004Cs-QH for qemu-devel@nongnu.org; Wed, 21 Sep 2016 16:00:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmngu-0005mh-74 for qemu-devel@nongnu.org; Wed, 21 Sep 2016 16:00:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmngt-0005li-Tr for qemu-devel@nongnu.org; Wed, 21 Sep 2016 16:00:24 -0400 References: <1474486942-18754-1-git-send-email-thuth@redhat.com> From: Eric Blake Message-ID: Date: Wed, 21 Sep 2016 15:00:21 -0500 MIME-Version: 1.0 In-Reply-To: <1474486942-18754-1-git-send-email-thuth@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="akwDauC4vLTv0eR9TxuRFgxs0PNWBOCqh" Subject: Re: [Qemu-devel] [PATCH v3] scripts: Add a script to check for bug URLs in the git log List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org Cc: Peter Maydell , stefanha@redhat.com, Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --akwDauC4vLTv0eR9TxuRFgxs0PNWBOCqh From: Eric Blake To: Thomas Huth , qemu-devel@nongnu.org Cc: Peter Maydell , stefanha@redhat.com, Paolo Bonzini Message-ID: Subject: Re: [PATCH v3] scripts: Add a script to check for bug URLs in the git log References: <1474486942-18754-1-git-send-email-thuth@redhat.com> In-Reply-To: <1474486942-18754-1-git-send-email-thuth@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/21/2016 02:42 PM, Thomas Huth wrote: > Basic idea of this script is to check the git log for URLs > to the QEMU bugtracker at launchpad.net and to figure out > whether the related bug has been marked there as "Fix released" > (i.e. closed) already. So this script can e.g. be used after > each public release of QEMU to check whether there are any > bug tickets that could be moved from "Fix committed" (or another > state if the author of the patch forgot to update the bug ticket) > to "Fix released". >=20 > Signed-off-by: Thomas Huth > --- > v3: Adressed Eric's review comments from v2 (fixed bashisms, more > POSIX compliance, use lower-case variable names, etc.) >=20 > + > +if [ "x$start" =3D "x" ]; then > + start=3D`git tag -l 'v[0-9]*\.[0-9]*.0' | tail -n 2 | head -n 1` > +fi > +if [ "x$end" =3D "x" ]; then > + end=3D`git tag -l 'v[0-9]*\.[0-9]*.0' | tail -n 1` This would match v1.100 (not that we are likely to have that tag); both lines are missing a \ before the second '.' if you are trying to constrain it to just vX.Y.Z forms. > +fi > + > +if [ "x$start" =3D "x" ] || [ "x$end" =3D "x" ]; then > + echo "Could not determine start or end revision ... Please note th= at this" > + echo "script must be run from a checked out git repository of QEMU= !" I'd drop the ending !; we don't need to shout at the user. At any rate, you have indeed addressed the portability issues I pointed out, so with the missing \ fixed, I'm okay with adding: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --akwDauC4vLTv0eR9TxuRFgxs0PNWBOCqh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX4ubVAAoJEKeha0olJ0NqOQwH/3EukCZZ8lYbfbknCfNaCjtp gNVuBEu1Zv7rgP0hf8LgTqiz2hATuSyacPzcIA62yr7IQEGOxYKxbhtghbZ8rKS0 jmNgOlpFH0iMMIiaTVrnDUPGSXpX7jR6zeXeducOtYVVKFNMirAAmNLu0r4NhGl6 fEgLQAbrmpyLpe0ohcI5mTaQxGJWozdZXBlVvm8tBG5rs7/eJC7QzvJYJkqOF2Io P8nX0LRxKKnJ04ktz4xIs9JH4NdEf+YpsAniokbXXPH2TsteHUr6GDlMPrWN1R7l bv5evufqyCMsQW3jhaaBBfiI8m+qphQrEPEk0E8CBL+O0aw7rygzy61dcoEOaWg= =s9fQ -----END PGP SIGNATURE----- --akwDauC4vLTv0eR9TxuRFgxs0PNWBOCqh--