qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michal Novotny <minovotn@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [QEMU-1.6 PATCH] vl.c: Output error on invalid machine type provided
Date: Mon, 12 Aug 2013 18:28:30 +0200	[thread overview]
Message-ID: <e50a063f65dc29381ce3301d74a61d6b1de0f5bc.1376324862.git.minovotn@redhat.com> (raw)

Output error message using qemu's error_report() function when user
provides the invalid machine type on the command line. This also saves
time to find what issue is when you downgrade from one version of qemu
to another that doesn't support required machine type yet (the version
user downgraded to have to have this patch applied too, of course).

Signed-off-by: Michal Novotny <minovotn@redhat.com>
---
 vl.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/vl.c b/vl.c
index f422a1c..9b4a3f9 100644
--- a/vl.c
+++ b/vl.c
@@ -2671,6 +2671,11 @@ static QEMUMachine *machine_parse(const char *name)
     if (machine) {
         return machine;
     }
+
+    if (name && !is_help_option(name)) {
+        error_report("Unsupported machine type");
+    }
+
     printf("Supported machines are:\n");
     for (m = first_machine; m != NULL; m = m->next) {
         if (m->alias) {
-- 
1.7.11.7

             reply	other threads:[~2013-08-12 16:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12 16:28 Michal Novotny [this message]
2013-08-12 16:47 ` [Qemu-devel] [QEMU-1.6 PATCH] vl.c: Output error on invalid machine type provided Eric Blake
2013-08-12 16:48   ` Michal Novotny
2013-08-12 17:06 ` Marcel Apfelbaum
2013-08-23 15:52 ` Michal Novotny
2013-08-23 17:32   ` Andreas Färber
2013-08-23 18:14     ` Markus Armbruster
2013-09-05 11:39 ` [Qemu-devel] [QEMU-1.6 & QEMU-Upstream " Daniel P. Berrange
2013-09-05 11:45   ` Michal Novotny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e50a063f65dc29381ce3301d74a61d6b1de0f5bc.1376324862.git.minovotn@redhat.com \
    --to=minovotn@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).