From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 10/10] xxhash: remove qemu_xxhash7
Date: Wed, 3 May 2023 11:07:35 +0100 [thread overview]
Message-ID: <e510ce0c-4ea5-a6f8-5575-bb82a0efcc48@linaro.org> (raw)
In-Reply-To: <20230503091756.1453057-11-alex.bennee@linaro.org>
On 5/3/23 10:17, Alex Bennée wrote:
> Now we no longer have users for qemu_xxhash7 we can drop an additional
> multiply and rol and make qemu_xxhash6 the implementation. Adjust the
> smaller hash functions accordingly.
>
> Message-Id: <20230420150009.1675181-11-alex.bennee@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> include/qemu/xxhash.h | 17 ++++-------------
> 1 file changed, 4 insertions(+), 13 deletions(-)
Oh, well, I noticed during this review that we're not hashing cs_base, so probably
expanding this to xxhash8 more proper.
cs_base is used for all kinds of important things, such as AArch64 flags expansion, so we
might get better hashing performance by including it.
r~
prev parent reply other threads:[~2023-05-03 10:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 9:17 [PATCH v2 00/10] tracing: remove dynamic vcpu state Alex Bennée
2023-05-03 9:17 ` [PATCH v2 01/10] *-user: remove the guest_user_syscall tracepoints Alex Bennée
2023-05-03 9:49 ` Richard Henderson
2023-05-03 9:17 ` [PATCH v2 02/10] trace-events: remove the remaining vcpu trace events Alex Bennée
2023-05-03 9:51 ` Richard Henderson
2023-05-03 9:17 ` [PATCH v2 03/10] trace: remove vcpu_id from the TraceEvent structure Alex Bennée
2023-05-03 9:52 ` Richard Henderson
2023-05-03 9:17 ` [PATCH v2 04/10] scripts/qapi: document the tool that generated the file Alex Bennée
2023-05-03 9:54 ` Richard Henderson
2023-05-03 9:17 ` [PATCH v2 05/10] qapi: make the vcpu parameters deprecated for 8.1 Alex Bennée
2023-05-03 9:55 ` Richard Henderson
2023-05-03 9:17 ` [PATCH v2 06/10] trace: remove code that depends on setting vcpu Alex Bennée
2023-05-03 9:58 ` Richard Henderson
2023-05-03 9:17 ` [PATCH v2 07/10] trace: remove control-vcpu.h Alex Bennée
2023-05-03 9:59 ` Richard Henderson
2023-05-03 9:17 ` [PATCH v2 08/10] tcg: remove the final vestiges of dstate Alex Bennée
2023-05-03 10:01 ` Richard Henderson
2023-05-03 9:17 ` [PATCH v2 09/10] hw/9pfs: use qemu_xxhash4 Alex Bennée
2023-05-03 10:04 ` Richard Henderson
2023-05-03 9:17 ` [PATCH v2 10/10] xxhash: remove qemu_xxhash7 Alex Bennée
2023-05-03 10:07 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e510ce0c-4ea5-a6f8-5575-bb82a0efcc48@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).