From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DEB9C77B61 for ; Mon, 24 Apr 2023 04:37:28 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqnw3-0004V7-FJ; Mon, 24 Apr 2023 00:36:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqnvz-0004Tq-C4 for qemu-devel@nongnu.org; Mon, 24 Apr 2023 00:36:15 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pqnvx-0001Hi-E8 for qemu-devel@nongnu.org; Mon, 24 Apr 2023 00:36:15 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-3f1950f5676so27415315e9.3 for ; Sun, 23 Apr 2023 21:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682310971; x=1684902971; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rGRC4M/xg5RvySFn6AUCpzfS3I3dPVkQtLaqMaINYlg=; b=BzdrVA1b+yH7PDYRSew4u+SsxQdBVhn5a4orw/I7kkMuT6lH1MVFX0tQ2Pixfm5C53 0CJC5y4Dsn8iYm6jmjhVLhawdrKgZSWeacul7biEURBD2oYcZWkJzulxxl2IfDVgmW/g wvjcYSrufXTGYA0E19fYn5eeG9Z0UV1YCqFjd20VJKFW68TKKDGNK99KgYH/eduJ4pMj DR004DlVovSOxiM/r+h0p5ytWQ20WNZqs0Qi7Qm2lbrSYRXEynbPkxnd6rCDVtnxxYxx foHB+/0eBrAiD0VZbp06IhfveT5EgLsde51Ij3Ffpg7uiBo6Jog6AIyzqJGyYmSSpyuw mjvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682310971; x=1684902971; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rGRC4M/xg5RvySFn6AUCpzfS3I3dPVkQtLaqMaINYlg=; b=BVjVXYAC/3XuL9jG9qM81cWhkg0NKfRomHq8+nrZWsX49pFo7zicyAVawx4vgLl5Xb HjpgFsu0K1gyh01TJllh7mYJWZGMVuj4O+cVFnCZwHFtfjJOokjm8T7c9eunnQvYFno9 sr4nfDpYi9k13OdeRiXyLX05eVnhIWuSpvWVMsaKx82/pU6GXmqfz1mcPGicsmD7+ktz Wxy+pUIo9mjYghaOfzPkalY+LqJF5mMnR1oI9iku4lGguzRrXAhTheLbfQwCDoKZCwQJ AaJbbAg+8Vu/FJCrBCRPegjKo2naNEJRfiPNL/dewPmprx5tJteg53DqcP1v7VNkX755 0Z+g== X-Gm-Message-State: AAQBX9c91AQl//e5pCM1IgJ31mgBJ9NW+G7tdA7Ex8YluDV+pNdtHSHS dr85Oi2lWP0THEbds53SPzyCfQ== X-Google-Smtp-Source: AKy350bZPxSB5+ezN04VmPKftjnjA1w6LbtMc3Wx7c4GvErmEd0lrUnwHJbcZI3HJTEJ/EIRtc3Gmg== X-Received: by 2002:adf:e948:0:b0:303:a2e4:e65b with SMTP id m8-20020adfe948000000b00303a2e4e65bmr6086539wrn.66.1682310970908; Sun, 23 Apr 2023 21:36:10 -0700 (PDT) Received: from [10.43.0.114] (cust-west-loneq8-46-193-226-34.wb.wifirst.net. [46.193.226.34]) by smtp.gmail.com with ESMTPSA id 25-20020a05600c025900b003ed2c0a0f37sm11088995wmj.35.2023.04.23.21.36.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Apr 2023 21:36:10 -0700 (PDT) Message-ID: Date: Mon, 24 Apr 2023 05:36:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 33/54] tcg: Introduce arg_slot_stk_ofs Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, qemu-ppc@nongnu.org References: <20230411010512.5375-1-richard.henderson@linaro.org> <20230411010512.5375-34-richard.henderson@linaro.org> <6f54a97a-306d-f375-1fc2-8faaf848ecd0@linaro.org> From: Richard Henderson In-Reply-To: <6f54a97a-306d-f375-1fc2-8faaf848ecd0@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.143, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, SUSPICIOUS_RECIPS=2.51, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 4/23/23 19:55, Philippe Mathieu-Daudé wrote: > On 11/4/23 03:04, Richard Henderson wrote: >> Unify all computation of argument stack offset in one function. >> This requires that we adjust ref_slot to be in the same units, >> by adding max_reg_slots during init_call_layout. >> >> Signed-off-by: Richard Henderson >> --- >>   tcg/tcg.c | 29 +++++++++++++++++------------ >>   1 file changed, 17 insertions(+), 12 deletions(-) > > >> +static inline int arg_slot_stk_ofs(unsigned arg_slot) >> +{ >> +    unsigned max = TCG_STATIC_CALL_ARGS_SIZE / sizeof(tcg_target_long); > > static const? No, compile-time constant folding and propagation. r~