From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>
Cc: "KONRAD Frederic" <frederic.konrad@adacore.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Fabien Chouteau" <chouteau@adacore.com>,
"Cleber Rosa" <crosa@redhat.com>
Subject: Re: [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default
Date: Sun, 29 Mar 2020 21:40:08 +0200 [thread overview]
Message-ID: <e52d2e63-f1fc-1d71-8abd-9cced388aa50@redhat.com> (raw)
In-Reply-To: <20200212203627.16592-1-philmd@redhat.com>
I just noticed I forgot to Cc Eduardo when posting this :S
Eduardo, do you want me to prepare a pullreq for rc1 with this patch and
Oksana other fix?
On 2/12/20 9:36 PM, Philippe Mathieu-Daudé wrote:
> The www.helenos.org server is slow and downloading the Leon3 binary
> takes too long [*]. Do not include this test in the default suite.
>
> Similarly to commit 471c97a69b:
>
> Currently the Avocado framework does not distinct the time spent
> downloading assets vs. the time spent running a test. With big
> assets (like a full VM image) the tests likely fail.
>
> This is a limitation known by the Avocado team.
> Until this issue get fixed, do not run this tests automatically.
>
> Tests can still be run setting the AVOCADO_TIMEOUT_EXPECTED
> environment variable.
>
> [*] https://travis-ci.org/stsquad/qemu/jobs/649599880#L4198
>
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: Add missing staged hunk...
> ---
> tests/acceptance/machine_sparc_leon3.py | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/acceptance/machine_sparc_leon3.py b/tests/acceptance/machine_sparc_leon3.py
> index f77e210ccb..27e4717a51 100644
> --- a/tests/acceptance/machine_sparc_leon3.py
> +++ b/tests/acceptance/machine_sparc_leon3.py
> @@ -5,6 +5,9 @@
> # This work is licensed under the terms of the GNU GPL, version 2 or
> # later. See the COPYING file in the top-level directory.
>
> +import os
> +
> +from avocado import skipUnless
> from avocado_qemu import Test
> from avocado_qemu import wait_for_console_pattern
>
> @@ -13,6 +16,7 @@ class Leon3Machine(Test):
>
> timeout = 60
>
> + @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
> def test_leon3_helenos_uimage(self):
> """
> :avocado: tags=arch:sparc
>
next prev parent reply other threads:[~2020-03-29 19:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 20:36 [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default Philippe Mathieu-Daudé
2020-02-13 20:28 ` Wainer dos Santos Moschetta
2020-02-17 11:51 ` KONRAD Frederic
2020-03-29 19:40 ` Philippe Mathieu-Daudé [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-02-12 20:36 Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e52d2e63-f1fc-1d71-8abd-9cced388aa50@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=chouteau@adacore.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=frederic.konrad@adacore.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).