qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Daniel P . Berrange" <berrange@redhat.com>,
	"John Snow" <jsnow@redhat.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [RFC PATCH 0/9] gitlab-ci: Allow forks to skip some build jobs
Date: Thu, 5 Nov 2020 08:22:08 +0100	[thread overview]
Message-ID: <e5416a27-af97-765e-afc4-e7309820ff9d@redhat.com> (raw)
In-Reply-To: <20201104224558.3384595-1-philmd@redhat.com>

On 11/4/20 11:45 PM, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> 2 months ago GitLab added time limit to their free CI offer [1].
> This series provide developers with the possibility to not run
> all jobs. By default all jobs are started, but we can disable
> a subset of them.
> 
> I think this should be the other way around (enable features one
> wants to test, with a default to the "all" keyword), but I didn't
> want to disrupt the current workflow.

I was a bit too focused on getting the YAML right to not realize
it is simpler to do:

QEMU_JOBS=all          # default, overwritable
QEMU_JOBS=system,fuzz  # only build those jobs
                       # can be set in fork UI config (see [2])
                       # can be set with git-push option (see below)

> I'm not sure supporting both ("SKIP_BUILD=3Dall INCLUDE_BUILD=3Dsystem")
> options is easy to implement, or to maintain (unlikely).
> 
> In the next iteration I'll add the possibility to use a project-
> wide environment variable [2] to set the default set of enabled /
> disabled features a fork is interested in. User will still be
> able to overload using git-push on the command line. A friendly
> way to use this feature is with git aliases [3]:
> 
>  $ git config alias.pushci_system \
>     'push -o ci.variable=3D"SKIP_BUILD=3Duser"'
>  $ git config alias.pushci_debian \
>     'push -o ci.variable=3D"SKIP_BUILD=3Dcentos,fedora,ubuntu"'
> 
> Then you can run the jobs based on Debian images (only) using:
> 
>  $ git pushci_debian gitlab_repo my_branch_for_debian
> 
> Or run all system-mode emulation jobs only using:
> 
>   $ git pushci_system my_gitlab_repo branch_with_system_feature
> 
> Comments welcomed!
> 
> Regards,
> 
> Phil.
> 
> [1] https://about.gitlab.com/releases/2020/09/01/ci-minutes-update-free-users/
> [2] https://docs.gitlab.com/ee/ci/variables/README.html#create-a-custom-varia=
> ble-in-the-ui
> [3] https://docs.gitlab.com/ee/user/project/push_options.html#useful-git-alia=
> ses
> 
> Philippe Mathieu-Daud=C3=A9 (9):
>   gitlab-ci: Replace YAML anchors by extends (cross_system_build_job)
>   gitlab-ci: Replace YAML anchors by extends (native_build_job)
>   gitlab-ci: Replace YAML anchors by extends (native_test_job)
>   gitlab-ci: Replace YAML anchors by extends (acceptance_test_job)
>   gitlab-ci: Rename acceptance_test_job -> integration_test_job
>   gitlab-ci: Extract common job definition as 'cross_common_job'
>   gitlab-ci: Extract common job definition as 'native_common_job'
>   gitlab-ci: Add rules to skip building cross-jobs
>   gitlab-ci: Add rules to skip building/testing native jobs
> 
>  .gitlab-ci.d/crossbuilds.yml |  57 +++++++++++--------
>  .gitlab-ci.yml               | 104 +++++++++++++++++++++--------------
>  2 files changed, 98 insertions(+), 63 deletions(-)
> 
> --=20
> 2.26.2
> 



      parent reply	other threads:[~2020-11-05  7:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-04 22:45 [RFC PATCH 0/9] gitlab-ci: Allow forks to skip some build jobs Philippe Mathieu-Daudé
2020-11-04 22:45 ` [RFC PATCH 1/9] gitlab-ci: Replace YAML anchors by extends (cross_system_build_job) Philippe Mathieu-Daudé
2020-11-04 22:45 ` [RFC PATCH 2/9] gitlab-ci: Replace YAML anchors by extends (native_build_job) Philippe Mathieu-Daudé
2020-11-04 22:45 ` [RFC PATCH 3/9] gitlab-ci: Replace YAML anchors by extends (native_test_job) Philippe Mathieu-Daudé
2020-11-04 22:45 ` [RFC PATCH 4/9] gitlab-ci: Replace YAML anchors by extends (acceptance_test_job) Philippe Mathieu-Daudé
2020-11-04 22:45 ` [RFC PATCH 5/9] gitlab-ci: Rename acceptance_test_job -> integration_test_job Philippe Mathieu-Daudé
2020-11-04 22:45 ` [RFC PATCH 6/9] gitlab-ci: Extract common job definition as 'cross_common_job' Philippe Mathieu-Daudé
2020-11-04 22:45 ` [RFC PATCH 7/9] gitlab-ci: Extract common job definition as 'native_common_job' Philippe Mathieu-Daudé
2020-11-04 22:45 ` [RFC PATCH 8/9] gitlab-ci: Add rules to skip building cross-jobs Philippe Mathieu-Daudé
2020-11-04 22:45 ` [RFC PATCH 9/9] gitlab-ci: Add rules to skip building/testing native jobs Philippe Mathieu-Daudé
2020-11-05  7:22 ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5416a27-af97-765e-afc4-e7309820ff9d@redhat.com \
    --to=philmd@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).