Re: [PATCH-for-10.2] hw/southbridge/lasi: Correct LasiState parent

[Gustavo Romero <gustavo.romero@linaro.org>]

Hi Phil,

On 11/17/25 06:18, Philippe Mathieu-Daudé wrote:
> TYPE_LASI_CHIP inherits from TYPE_SYS_BUS_DEVICE, not
> TYPE_PCI_HOST_BRIDGE, so its parent structure is of
> SysBusDevice type.
> 
> Fixes: 376b851909d ("hppa: Add support for LASI chip with i82596 NIC")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/hw/misc/lasi.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

oh, right :)

Reviewed-by: Gustavo Romero <gustavo.romero@linaro.org>


> diff --git a/include/hw/misc/lasi.h b/include/hw/misc/lasi.h
> index 04312d0b589..0e95be1c32a 100644
> --- a/include/hw/misc/lasi.h
> +++ b/include/hw/misc/lasi.h
> @@ -13,8 +13,8 @@
>   #define LASI_H
>   
>   #include "system/address-spaces.h"
> -#include "hw/pci/pci_host.h"
>   #include "hw/boards.h"
> +#include "hw/sysbus.h"
>   
>   #define TYPE_LASI_CHIP "lasi-chip"
>   OBJECT_DECLARE_SIMPLE_TYPE(LasiState, LASI_CHIP)
> @@ -63,7 +63,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(LasiState, LASI_CHIP)
>   #define LASI_IRQ_PS2MOU_HPA 26
>   
>   struct LasiState {
> -    PCIHostState parent_obj;
> +    SysBusDevice parent_obj;
>   
>       uint32_t irr;
>       uint32_t imr;