qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h
Date: Thu, 8 Nov 2018 14:09:59 +0100	[thread overview]
Message-ID: <e5617372-b4dc-e602-e565-421bbef000f4@redhat.com> (raw)
In-Reply-To: <20181108125223.30804-1-peter.maydell@linaro.org>

On 8/11/18 13:52, Peter Maydell wrote:
> The guest-agent-core.h header was missing the usual guards
> against multiple inclusion; add them.
> 
> (Spotted by lgtm.com's static analyzer.)
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>   qga/guest-agent-core.h | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/qga/guest-agent-core.h b/qga/guest-agent-core.h
> index 6f4d214cb9f..60eae16f27a 100644
> --- a/qga/guest-agent-core.h
> +++ b/qga/guest-agent-core.h
> @@ -10,6 +10,9 @@
>    * This work is licensed under the terms of the GNU GPL, version 2 or later.
>    * See the COPYING file in the top-level directory.
>    */
> +#ifndef GUEST_AGENT_CORE_H
> +#define GUEST_AGENT_CORE_H
> +
>   #include "qapi/qmp/dispatch.h"
>   #include "qemu-common.h"
>   #include "qga-qapi-types.h"
> @@ -46,3 +49,5 @@ int ga_parse_whence(GuestFileWhence *whence, Error **errp);
>   #ifndef _WIN32
>   void reopen_fd_to_null(int fd);
>   #endif
> +
> +#endif /* GUEST_AGENT_CORE_H */
> 

  parent reply	other threads:[~2018-11-08 13:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08 12:52 [Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h Peter Maydell
2018-11-08 12:57 ` Marc-André Lureau
2018-11-08 13:09 ` Philippe Mathieu-Daudé [this message]
2018-11-09 14:38 ` Michael Roth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5617372-b4dc-e602-e565-421bbef000f4@redhat.com \
    --to=philmd@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).